Noticed a SACC violation in code...

63 views
Skip to first unread message

Sam Habiel

unread,
May 17, 2012, 6:54:01 PM5/17/12
to CCD-CCR-project
http://www.hardhats.org/tools/sac96.html

2.3.2.5.1 The global ^TMP will be used as a scratch global within a
session. The first subscript shall be $J, or the first two subscripts
shall be a package namespaced subscript followed by $J.

^TMP("C0CCCR","ODIR") is illegal.

I would rather use the Kernel Standard $$DEFDIR^%ZISH which will get
you the default directory according to the Kernel. In Unix systems it
defaults to /tmp/.

As a further design point, it's possible to get a default directory
which is set by the user in a new field in the C0C Parameters file; if
that isn't present, we should use $$DEFDIR^%ZISH.

Ravi, if you want to fix this, I would appreciate it.

Sam

Sanchu Shanmugam

unread,
May 18, 2012, 9:45:03 AM5/18/12
to ccd-ccr...@googlegroups.com, sanchus, Ravikumar Kandasamy
Sam

Thanks for pointing this out.

We will try to address this as part next release

regards
Sanchu S
OHUM Healthcare 
Skype: sanchu.shanmugam


Sam

--
You received this message because you are subscribed to the Google Groups "CCD-CCR-project" group.
To post to this group, send email to ccd-ccr...@googlegroups.com.
To unsubscribe from this group, send email to ccd-ccr-proje...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/ccd-ccr-project?hl=en.


Sam Habiel

unread,
May 18, 2012, 11:50:12 AM5/18/12
to ccd-ccr...@googlegroups.com, sanchus, Ravikumar Kandasamy
For a future version, we should run ^XINDEX and find the problems it
talks about. Just FYI.

Sam

Michael Cham

unread,
May 21, 2012, 10:44:15 AM5/21/12
to ccd-ccr...@googlegroups.com, sanchus, Ravikumar Kandasamy
I don't know if anyone is dependent on the "ODIR" function currently.  Sam is right, but is there a graceful end of life?
Mike


On Friday, May 18, 2012 9:45:03 AM UTC-4, Sanchus wrote:
Sam

Thanks for pointing this out.

We will try to address this as part next release

regards
Sanchu S
OHUM Healthcare 
Skype: sanchu.shanmugam

On Fri, May 18, 2012 at 4:24 AM, Sam Habiel <sam.h...@gmail.com> wrote:
http://www.hardhats.org/tools/sac96.html

2.3.2.5.1 The global ^TMP will be used as a scratch global within a
session. The first subscript shall be $J, or the first two subscripts
shall be a package namespaced subscript followed by $J.

^TMP("C0CCCR","ODIR") is illegal.

I would rather use the Kernel Standard $$DEFDIR^%ZISH which will get
you the default directory according to the Kernel. In Unix systems it
defaults to /tmp/.

As a further design point, it's possible to get a default directory
which is set by the user in a new field in the C0C Parameters file; if
that isn't present, we should use $$DEFDIR^%ZISH.

Ravi, if you want to fix this, I would appreciate it.

Sam

--
You received this message because you are subscribed to the Google Groups "CCD-CCR-project" group.
To post to this group, send email to ccd-ccr-project@googlegroups.com.
To unsubscribe from this group, send email to ccd-ccr-project+unsubscribe@googlegroups.com.

Sam Habiel

unread,
May 21, 2012, 11:32:19 AM5/21/12
to ccd-ccr...@googlegroups.com, sanchus, Ravikumar Kandasamy
Michael,

I have been thinking about this. On a production system, when it is
restarted, ^TMP is thrown away. Therefore, if CCD/CCR uses this ^TMP
after restart, it's not going to work. I don't believe this affects
the RPC method of accessing the CCD/CCR.

ODIR can be the default Kernel one is which is guaranteed to be
defined on any VISTA system. So it will "degrade" gracefully.

Sam
>>> To post to this group, send email to ccd-ccr...@googlegroups.com.
>>> To unsubscribe from this group, send email to
>>> ccd-ccr-proje...@googlegroups.com.
>>> For more options, visit this group at
>>> http://groups.google.com/group/ccd-ccr-project?hl=en.
>>>
>>
> --
> You received this message because you are subscribed to the Google Groups
> "CCD-CCR-project" group.
> To view this discussion on the web visit
> https://groups.google.com/d/msg/ccd-ccr-project/-/7pcEwKGqCf4J.
>
> To post to this group, send email to ccd-ccr...@googlegroups.com.
> To unsubscribe from this group, send email to
> ccd-ccr-proje...@googlegroups.com.

skip ormsby

unread,
May 21, 2012, 12:13:49 PM5/21/12
to ccd-ccr...@googlegroups.com
Attached are the rules of the road when using XTMP.

To view this discussion on the web visit https://groups.google.com/d/msg/ccd-ccr-project/-/7pcEwKGqCf4J.
To post to this group, send email to ccd-ccr...@googlegroups.com.
To unsubscribe from this group, send email to ccd-ccr-proje...@googlegroups.com.
xtmp_rules.pdf

Sam Habiel

unread,
May 21, 2012, 12:26:56 PM5/21/12
to ccd-ccr...@googlegroups.com
Thank you Skip. I haven't seen this before; it's very helpful.

Sam
>>>> To post to this group, send email to ccd-ccr...@googlegroups.com.
>>>> To unsubscribe from this group, send email to
>>>> ccd-ccr-proje...@googlegroups.com.
>>>> For more options, visit this group at
>>>> http://groups.google.com/group/ccd-ccr-project?hl=en.
>>>>
>>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "CCD-CCR-project" group.
>> To view this discussion on the web visit
>> https://groups.google.com/d/msg/ccd-ccr-project/-/7pcEwKGqCf4J.
>> To post to this group, send email to ccd-ccr...@googlegroups.com.
>> To unsubscribe from this group, send email to
>> ccd-ccr-proje...@googlegroups.com.
>> For more options, visit this group at
>> http://groups.google.com/group/ccd-ccr-project?hl=en.
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "CCD-CCR-project" group.

Michael Cham

unread,
May 21, 2012, 3:05:35 PM5/21/12
to ccd-ccr...@googlegroups.com, sanchus, Ravikumar Kandasamy
Sam,
This definitely does not effect RPC, only the EXPORT and XPAT.  The only scenario I wonder about is if someone has developed scripts that are coded to set TMP, and then looks for files in the directory specified.  EXPORT is probably the biggest offender, since XPAT can take a directory as an argument.  
Not sure if it worth worrying about.
Mike

>>> To post to this group, send email to ccd-ccr-project@googlegroups.com.
>>> To unsubscribe from this group, send email to
>>> For more options, visit this group at
>>> http://groups.google.com/group/ccd-ccr-project?hl=en.
>>>
>>
> --
> You received this message because you are subscribed to the Google Groups
> "CCD-CCR-project" group.
> To view this discussion on the web visit
> https://groups.google.com/d/msg/ccd-ccr-project/-/7pcEwKGqCf4J.
>
> To post to this group, send email to ccd-ccr-project@googlegroups.com.
> To unsubscribe from this group, send email to

LD 'Gus' Landis

unread,
May 21, 2012, 3:23:38 PM5/21/12
to ccd-ccr...@googlegroups.com
On Mon, May 21, 2012 at 10:13 AM, skip ormsby <skip....@gmail.com> wrote:
Attached are the rules of the road when using XTMP.


Dear Skip,

The link in that document to the SAC (http://vaww.vista.med.va.gov/sacc/)
appears to be dead.  Is it behind the VA's firewall?

Cheers,
  --ldl

--
---
NOTE: If it is important CALL ME - I may miss email,
which I do NOT normally check on weekends nor on
a regular basis during any other day.
---
LD Landis - N0YRQ - de la tierra del encanto
3960 Schooner Loop, Las Cruces, NM 88012
651-340-4007  N32 21'48.28" W106 46'5.80"

skip ormsby

unread,
May 21, 2012, 4:05:11 PM5/21/12
to ccd-ccr...@googlegroups.com
Hmm ... thought I attached the actual document.  In any case the document can be found here:

http://www.va.gov/vdl/application.asp?appid=10

scroll down to the bottom and look for "XTMP Global Description Rules of Use".

--
You received this message because you are subscribed to the Google Groups "CCD-CCR-project" group.

Nancy Anthracite

unread,
May 21, 2012, 4:59:43 PM5/21/12
to ccd-ccr...@googlegroups.com
Yes, that is behind the firewall. I suspect OSEHRA has a copy on their website.

Sent via my Samsung Galaxy Prevail from Boost Mobile

LD 'Gus' Landis

unread,
May 21, 2012, 5:47:29 PM5/21/12
to ccd-ccr...@googlegroups.com
On Mon, May 21, 2012 at 2:05 PM, skip ormsby <skip....@gmail.com> wrote:
Hmm ... thought I attached the actual document.  In any case the document can be found here:

http://www.va.gov/vdl/application.asp?appid=10

scroll down to the bottom and look for "XTMP Global Description Rules of Use".



Dear Skip,

Re: the attachment
Yes you did attach the rules for ^XTMP, but that document had a link for (what I
thought was) the entire SAC document.  I have something that was said to be the
current SAC from a few years ago... was looking for an update. Thanks!

Sam Habiel

unread,
May 21, 2012, 6:18:39 PM5/21/12
to ccd-ccr...@googlegroups.com
Gus,

Latest SACC is here: http://www.hardhats.org/tools/sac07.html

Sam

On Mon, May 21, 2012 at 2:47 PM, LD 'Gus' Landis <ldla...@gmail.com> wrote:

Sam Habiel

unread,
May 23, 2012, 11:44:10 AM5/23/12
to ccd-ccr...@googlegroups.com, sanchus, Ravikumar Kandasamy
Mike,

I will talk it over with George.

OHUM just packaged version 1.2. I want to confirm with George that we
are releasing that officially. I am using 1.2 as my dependency for
other packages. The 1.1 version couldn't be used as a dependency
because it did not have a package file element.

Any changes I think will go into 1.3 now.

Sam
>> >>> To post to this group, send email to ccd-ccr...@googlegroups.com.
>> >>> To unsubscribe from this group, send email to
>> >>> ccd-ccr-proje...@googlegroups.com.
>> >>> For more options, visit this group at
>> >>> http://groups.google.com/group/ccd-ccr-project?hl=en.
>> >>>
>> >>
>> > --
>> > You received this message because you are subscribed to the Google
>> > Groups
>> > "CCD-CCR-project" group.
>> > To view this discussion on the web visit
>> > https://groups.google.com/d/msg/ccd-ccr-project/-/7pcEwKGqCf4J.
>> >
>> > To post to this group, send email to ccd-ccr...@googlegroups.com.
>> > To unsubscribe from this group, send email to
>> > ccd-ccr-proje...@googlegroups.com.
>> > For more options, visit this group at
>> > http://groups.google.com/group/ccd-ccr-project?hl=en.
>
> --
> You received this message because you are subscribed to the Google Groups
> "CCD-CCR-project" group.
> To view this discussion on the web visit
> https://groups.google.com/d/msg/ccd-ccr-project/-/rZAegJ5kF7AJ.
>
> To post to this group, send email to ccd-ccr...@googlegroups.com.
> To unsubscribe from this group, send email to
> ccd-ccr-proje...@googlegroups.com.
Reply all
Reply to author
Forward
0 new messages