[castle][JIRA] Created: (MR-396) WindsorDynamicActionProviderFactory and Friends - Get WindsorIntegration on DynamicActionProviders now

[Mike Nichols (JIRA)]

WindsorDynamicActionProviderFactory and Friends - Get WindsorIntegration on DynamicActionProviders now
------------------------------------------------------------------------------------------------------

Key: MR-396
URL: http://support.castleproject.org//browse/MR-396
Project: MonoRail
Issue Type: Patch
Components: Core
Affects Versions: Future
Reporter: Mike Nichols
Attachments: monorail.framework.dynamicactionprovider-windsorintegration.patch

This patch enables IDynamicActionProvider implementations to be included in WIndsorIntegration wiring for Controller consumption.
Basically, I followed the same semantics as IFilter throughout (with all the various factories for descriptors, providers, and so on).
I updated tests to include the new service as well.

All tests are passing after this update. I think this opens a whole new way of working for me....

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://support.castleproject.org//secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

[Mike Nichols (JIRA)]

[ http://support.castleproject.org//browse/MR-396?page=comments#action_12480 ]

Mike Nichols commented on MR-396:
---------------------------------

This patch has grown stale...would you like me to update to a more recent version ?

> WindsorDynamicActionProviderFactory and Friends - Get WindsorIntegration on DynamicActionProviders now
> ------------------------------------------------------------------------------------------------------
>
> Key: MR-396
> URL: http://support.castleproject.org//browse/MR-396
> Project: MonoRail
> Issue Type: Patch
> Components: Core
> Affects Versions: Future
> Reporter: Mike Nichols

> Assigned To: hamilton verissimo

[hamilton verissimo (JIRA)]

[ http://support.castleproject.org//browse/MR-396?page=comments#action_12519 ]

hamilton verissimo commented on MR-396:
---------------------------------------

Yes, please!

> WindsorDynamicActionProviderFactory and Friends - Get WindsorIntegration on DynamicActionProviders now
> ------------------------------------------------------------------------------------------------------
>
> Key: MR-396
> URL: http://support.castleproject.org//browse/MR-396
> Project: MonoRail
> Issue Type: Patch
> Components: Core
> Affects Versions: Future
> Reporter: Mike Nichols

> Assigned To: hamilton verissimo

[Mike Nichols (JIRA)]

[ http://support.castleproject.org//browse/MR-396?page=all ]

Mike Nichols updated MR-396:
----------------------------

Attachment: monorail.framework.dynamicactionprovider-windsorintegration-AGAIN.patch

Ok here is the latest revision r4841 with all the trappings for windsor dynamic action providers.
The tests aren't passing but I don't think that is due to the code herein...it's bombing somewhere on the cache tests.

I've been using this patch for about 2 months and it works great. Now I have hierarchies of actions instead of controllers.

> WindsorDynamicActionProviderFactory and Friends - Get WindsorIntegration on DynamicActionProviders now
> ------------------------------------------------------------------------------------------------------
>
> Key: MR-396
> URL: http://support.castleproject.org//browse/MR-396
> Project: MonoRail
> Issue Type: Patch
> Components: Core
> Affects Versions: Future
> Reporter: Mike Nichols

> Assigned To: hamilton verissimo
> Attachments: monorail.framework.dynamicactionprovider-windsorintegration-AGAIN.patch, monorail.framework.dynamicactionprovider-windsorintegration.patch

[Roelof Blom (JIRA)]

[ http://support.castleproject.org//browse/MR-396?page=comments#action_12663 ]

Roelof Blom commented on MR-396:
--------------------------------

Mike, the patch has gone stale again, sorry for that.

Would you be so kind to submit a new one? If you do, could you use tabs instead of spaces?

-- Roelof.

> WindsorDynamicActionProviderFactory and Friends - Get WindsorIntegration on DynamicActionProviders now
> ------------------------------------------------------------------------------------------------------
>
> Key: MR-396
> URL: http://support.castleproject.org//browse/MR-396
> Project: MonoRail
> Issue Type: Patch
> Components: Core
> Affects Versions: Future
> Reporter: Mike Nichols

> Assigned To: hamilton verissimo
> Attachments: monorail.framework.dynamicactionprovider-windsorintegration-AGAIN.patch, monorail.framework.dynamicactionprovider-windsorintegration.patch

[Mike Nichols (JIRA)]

[ http://support.castleproject.org//browse/MR-396?page=all ]

Mike Nichols updated MR-396:
----------------------------

Attachment: monorail.framework.dynamicactionprovider-windsorintegration-042908.patch

This is current as of 4/29/2008.
I have fixed the tabbing and was certain to include disclaimer on all new files.
I had another test to apply but it was a new folder and wanted to get this out the door and coverage is comparable to filter/windsor integration since the pattern is similar.

> WindsorDynamicActionProviderFactory and Friends - Get WindsorIntegration on DynamicActionProviders now
> ------------------------------------------------------------------------------------------------------
>
> Key: MR-396
> URL: http://support.castleproject.org//browse/MR-396
> Project: MonoRail
> Issue Type: Patch
> Components: Core
> Affects Versions: Future
> Reporter: Mike Nichols

> Assigned To: hamilton verissimo
> Attachments: monorail.framework.dynamicactionprovider-windsorintegration-042908.patch, monorail.framework.dynamicactionprovider-windsorintegration-AGAIN.patch, monorail.framework.dynamicactionprovider-windsorintegration.patch

[Roelof Blom (JIRA)]

[ http://support.castleproject.org//browse/MR-396?page=comments#action_12696 ]

Roelof Blom commented on MR-396:
--------------------------------

Strange, but the patch fails on the copyright lines of MockService.cs and DefaultControllerDescriptorProviderTestCase.cs

> WindsorDynamicActionProviderFactory and Friends - Get WindsorIntegration on DynamicActionProviders now
> ------------------------------------------------------------------------------------------------------
>
> Key: MR-396
> URL: http://support.castleproject.org//browse/MR-396
> Project: MonoRail
> Issue Type: Patch
> Components: Core
> Affects Versions: Future
> Reporter: Mike Nichols

> Assigned To: hamilton verissimo
> Attachments: monorail.framework.dynamicactionprovider-windsorintegration-042908.patch, monorail.framework.dynamicactionprovider-windsorintegration-AGAIN.patch, monorail.framework.dynamicactionprovider-windsorintegration.patch

[Roelof Blom (JIRA)]

[ http://support.castleproject.org//browse/MR-396?page=comments#action_12699 ]

Roelof Blom commented on MR-396:
--------------------------------

Applied in r5053, many thanks!

You can attach the patch that creates a folder as zip, I will add the folder manually.

> WindsorDynamicActionProviderFactory and Friends - Get WindsorIntegration on DynamicActionProviders now
> ------------------------------------------------------------------------------------------------------
>
> Key: MR-396
> URL: http://support.castleproject.org//browse/MR-396
> Project: MonoRail
> Issue Type: Patch
> Components: Core
> Affects Versions: Future
> Reporter: Mike Nichols

> Assigned To: hamilton verissimo
> Attachments: monorail.framework.dynamicactionprovider-windsorintegration-042908.patch, monorail.framework.dynamicactionprovider-windsorintegration-AGAIN.patch, monorail.framework.dynamicactionprovider-windsorintegration.patch