Pagination Release Patches

[Daniel Hölbling]

Could someone please apply these patches for the Pagination release?

Since I have no commit access I have to defer most of the work to someone who has both (commit access and SF access)

What needs work:

apply both: comp-issue-102.patch and pagination-release.patch

delete Pagination\src\Castle.Components.Pagination\Castle.Components.Pagination.build (it was replaced by default.build)

The new Version number would be 1.1.0.0. I hope that's ok.

As for changes.txt: I did a svn log on the repo and could not find any significant changes since GenericPage was added in Sept. 2008. 

I don't really know if that's a change from 1.0. Also, where would be the changes.txt file mentioned in the release guide?

Btw: What's the Nant target for creating a release build? I can't seem to find the right one to check if all artifacts are created.

greetings Daniel

[Jonathon Rossi]

Sorry for taking a while to get to this. The rest is inline.

On Sat, Nov 28, 2009 at 9:35 AM, Daniel Hölbling <tigr...@tigraine.at> wrote:

Could someone please apply these patches for the Pagination release?

Since I have no commit access I have to defer most of the work to someone who has both (commit access and SF access)

What needs work:

apply both: comp-issue-102.patch and pagination-release.patch

I have applied the 102 patch and closed the issue. See below for the second patch.

delete Pagination\src\Castle.Components.Pagination\Castle.Components.Pagination.build (it was replaced by default.build)

We don't want to delete these yet because the full castle build is using them.

The new Version number would be 1.1.0.0. I hope that's ok.

It is up to you, but the Pagination project has never had a release so you may want to use 1.0. Or we could ignore that so it doesn't sound like the release is from the RC3 days. I haven't committed the second patch, let me know what you want to do and I'll commit it.
 

As for changes.txt: I did a svn log on the repo and could not find any significant changes since GenericPage was added in Sept. 2008. 

As expected.

I don't really know if that's a change from 1.0. Also, where would be the changes.txt file mentioned in the release guide?

The project didn't actually have a Changes.txt, I have created one which we can add things to if needed. This file will automatically become part of the package zip file.

Btw: What's the Nant target for creating a release build? I can't seem to find the right one to check if all artifacts are created.

nant -D:project.config=release package build      // will build just the release package
nant merge package build      // will build both debug and release packages
 

greetings Daniel

--

You received this message because you are subscribed to the Google Groups "Castle Project Development List" group.
To post to this group, send email to castle-pro...@googlegroups.com.
To unsubscribe from this group, send email to castle-project-d...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/castle-project-devel?hl=en.

--
Jono

[John Simons]

Also, where would be the changes.txt file mentioned in the release guide?

I think I forgot that step, a patch would be welcomed.

Cheers John

On 29/11/2009, at 2:45 PM, Jonathon Rossi <jo...@jonorossi.com> wrote:

Also, where would be the changes.txt file mentioned in the release guide?

---

Last chance to win a Sony entertainment pack thanks to Yahoo!7. Hurry, ends Nov 30. Enter now.

[Daniel Hölbling]

Thanks Jono.

I believe we should bump to 1.1 to differentiate from the rc3 times and keep it more in line with the other Component releases that are also bumping their minor number.

greetings Daniel

[Jonathon Rossi]

Sure.

I have applied the version number patch. I moved the version number from the specific project into the root build file and used project.version.

Once you are ready to release we'll get the release date into the Changes.txt, get the built package from TeamCity and upload it to sf.net.

Thanks

[Daniel Hölbling]

Thanks. I'll look into that in the evening.

[Jonathon Rossi]

It is evening in +10 now, so take that in mind if I don't reply, I won't be purposely trying to ignore you :)

[Daniel Hölbling]

Yes I remembered the time-difference after posting. Unfortunately I'm currently at University at a course. Pagination release will have to wait for tomorrow.

greetings Daniel

[Daniel Hölbling]

Ok I just looked through the code and can't see anything wrong with it. 

Could someone make the release?

greetings Daniel