Groups keyboard shortcuts have been updated
Dismiss
See shortcuts

threading related pull request for dynamic proxy

7 views
Skip to first unread message

Krzysztof Kozmic

unread,
Jun 25, 2014, 8:29:02 AM6/25/14
to castle-pro...@googlegroups.com

anyone has any objections against merging this one?

-- 
Krzysztof Kozmic

hammett

unread,
Jun 25, 2014, 11:19:51 AM6/25/14
to castle-pro...@googlegroups.com
Makes sense. +1
> --
> You received this message because you are subscribed to the Google Groups
> "Castle Project Development List" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to castle-project-d...@googlegroups.com.
> To post to this group, send email to castle-pro...@googlegroups.com.
> Visit this group at http://groups.google.com/group/castle-project-devel.
> For more options, visit https://groups.google.com/d/optout.



--
Cheers,
hammett
http://www.d-collab.com/
http://www.hammettblog.com/

Ken Egozi

unread,
Jun 25, 2014, 4:56:34 PM6/25/14
to Castle Project Development List
looks legit, +1

Ken Egozi

unread,
Jun 25, 2014, 5:00:58 PM6/25/14
to Castle Project Development List
with a minor comment on the code (extracting the cacheType variable to outer scope might not be required, though I only looked at the diff, I might be missing something in the bigger picture)



Krzysztof Kozmic

unread,
Jun 26, 2014, 6:32:28 AM6/26/14
to castle-pro...@googlegroups.com
It got merged, and using our recently added nightly nugget feed I built a non-scientific experiment running this in a console app on my 4 core (HT) MacBook Pro.  It squarely falls into micro optimisation bucket as any performance difference I noticed (ran a few scenarios, with varying number of iterations and proxy types) is almost negligible.


-- 
Krzysztof Kozmic

Ken Egozi

unread,
Jun 26, 2014, 10:01:52 AM6/26/14
to Krzysztof Kozmic, castle-pro...@googlegroups.com
Might be a silly change but what if you switch the for loops?

Sent from my Windows Phone
From: Krzysztof Kozmic
Sent: ‎6/‎26/‎2014 3:32 AM
To: castle-pro...@googlegroups.com

hammett

unread,
Jun 26, 2014, 11:11:06 AM6/26/14
to castle-pro...@googlegroups.com
But there's no harm, is there? If there was a downgrade in perf, i'd
be worried (not really)

On Thu, Jun 26, 2014 at 7:32 AM, Krzysztof Kozmic
Reply all
Reply to author
Forward
0 new messages