Ignored fields are still validated

[Rémi BOURGAREL]

If we specify some fields to ignore they are still getting validated.

The following test fails

        [Test]
        public void IgnoredFieldsNotValidated()
        {
            var args = new NameValueCollection { { "person.Email", string.Empty }};
            object instance = binder.BindObject(typeof(Person), "person","person.Email",null, builder.BuildSourceNode(args));

            Assert.IsNotNull(instance);
            Assert.AreEqual(0, binder.ErrorList.Count);
        }

  Expected: 0
  But was:  1

The best solutions would be to add a call to ShouldIgnoreProperty in the function CheckForValidationFailures, the validation will still be done but it won't be added to the error list. Because it seems that it will be too muche complicated to add the ignored properties list to the validation interface (IValidatorRunner and IValidatorPerformer).

no ?
 

 

[hammett]

Patch? :-)

2012/1/26 Rémi BOURGAREL <bourgar...@gmail.com>:

> --
> You received this message because you are subscribed to the Google Groups
> "Castle Project Development List" group.
> To view this discussion on the web visit
> https://groups.google.com/d/msg/castle-project-devel/-/Oks1eu7Ehi8J.
> To post to this group, send email to castle-pro...@googlegroups.com.
> To unsubscribe from this group, send email to
> castle-project-d...@googlegroups.com.
> For more options, visit this group at
> http://groups.google.com/group/castle-project-devel?hl=en.

--
Cheers,
hammett
http://hammett.castleproject.org/

[Rémi BOURGAREL]

I'm fighting with git (I'm just know the svn way of doing things) and I'll add it to my fork... (I could use the castle.monorail gitwith tortoisesvn but I can't with castle.core, that's odd)

Rémi

Rémi BOURGAREL
Téléphone : +336 49 16 78 57
Adresse : 82 Rue Matabiau , 31 000 Toulouse, France

[Rémi BOURGAREL]

I commited it to my fork https://github.com/RemiBou/Core

I had to change a few private method's signature.

Unit Tests are OK.

Rémi

[G. Richard Bellamy]

Rémi,

Thanks for the work.

Did you mean TortoiseGit rather than TortoiseSvn?

Make sure you use Tabs rather than spaces. And then, once you've cleaned up the formatting, go ahead and create a GitHub pull request.

-rb

[Rémi BOURGAREL]

https://github.com/RemiBou/Core/commit/441a9c2c375be153b0db2cb7b029b1955b236310

is it better ?

rémi

[hammett]

Yup. Could you send a PR?

2012/2/6 Rémi BOURGAREL <bourgar...@gmail.com>:

> https://github.com/RemiBou/Core/commit/441a9c2c375be153b0db2cb7b029b1955b236310
>
> is it better ?
>
> rémi
>

> --
> You received this message because you are subscribed to the Google Groups
> "Castle Project Development List" group.
> To view this discussion on the web visit

> https://groups.google.com/d/msg/castle-project-devel/-/ncpFtptCk10J.

[Rémi BOURGAREL]

Done ! (right ?)