Does cascading used a patched janino-2.5.16?

16 views
Skip to first unread message

dha

unread,
Oct 22, 2010, 1:02:14 PM10/22/10
to cascading-user
Hi, everyone,

I just compared the janino jar that is bundled with cascading with the
version I downloaded from the janino home page. Some of the class
files don't match up.

$ md5sum -c ~/tmp/checksums 2> /dev/null | grep -v OK
./META-INF/MANIFEST.MF: FAILED
./META-INF/DUMMY.SF: FAILED
./META-INF/DUMMY.DSA: FAILED
./org/codehaus/janino/util/StringPattern.class: FAILED
./org/codehaus/janino/util/AutoIndentWriter.class: FAILED
./org/codehaus/janino/UnparseVisitor.class: FAILED
./org/codehaus/janino/Java.class: FAILED
./org/codehaus/janino/Java$LocalVariable.class: FAILED

I disassembled these classes using javap -c, and the disassembled
output for all the classes except for UnparseVisitor match.

From where did the janino jar in the cascading package originate?


Thanks,
-David

http://dist.codehaus.org/janino/janino-2.5.16.zip

dha

unread,
Oct 22, 2010, 1:39:36 PM10/22/10
to cascading-user
Also, I just noticed the bundled tagsoup-1.2.jar does not match the
version from the tagsoup download site (http://home.ccil.org/~cowan/
XML/tagsoup/tagsoup-1.2.jar).

$ md5sum -c ~/tmp/checksums 2> /dev/null | grep -v OK
./META-INF/MANIFEST.MF: FAILED
./org/ccil/cowan/tagsoup/PYXScanner.class: FAILED
./org/ccil/cowan/tagsoup/CommandLine.class: FAILED
./org/ccil/cowan/tagsoup/Parser$1.class: FAILED
./org/ccil/cowan/tagsoup/Parser.class: FAILED

All the class files disassembled the same except for CommandLine.
Running strings on CommandLine.class turned up this interesting
nugget:

--version
TagSoup version 1.1.3


Not sure how the CommandLine.class for v1.1.3 ended up in
tagsoup-1.2.jar. Running strings on the version downloaded directly
from tagsoup showed the correct version number.


Thanks,
-David

Chris K Wensel

unread,
Oct 22, 2010, 2:34:49 PM10/22/10
to cascadi...@googlegroups.com
None of the jars are patched, and are pulled directly from the distribution tars from the site.

Cascading 1.2 will pull directly from maven repos.

ckw

> --
> You received this message because you are subscribed to the Google Groups "cascading-user" group.
> To post to this group, send email to cascadi...@googlegroups.com.
> To unsubscribe from this group, send email to cascading-use...@googlegroups.com.
> For more options, visit this group at http://groups.google.com/group/cascading-user?hl=en.
>

--
Chris K Wensel
ch...@concurrentinc.com
http://www.concurrentinc.com

-- Concurrent, Inc. offers mentoring, support, and licensing for Cascading

Reply all
Reply to author
Forward
0 new messages