Issue 58 in casacore: Compiler errors with g++ 4.7.2

[casa...@googlecode.com]

Status: New
Owner: ----
Labels: Type-Defect Priority-Medium Milestone-Release1.4

New issue 58 by nicokrui...@gmail.com: Compiler errors with g++ 4.7.2
http://code.google.com/p/casacore/issues/detail?id=58

Hi,

When compiling on ubuntu 12.10, I encountered a few compiler errors. The
diff below should fix them.

Best regards,
Nico


diff
-r ./casa/Arrays/ArrayBase.h ../orig/casacore-1.5.0/casa/Arrays/ArrayBase.h
30a31

34,35d34
<
< #include <unistd.h>
diff
-r ./casa/Arrays/IPosition.h ../orig/casacore-1.5.0/casa/Arrays/IPosition.h
37d36
< #include <unistd.h>
diff -r ./casa/BasicMath/Math.h ../orig/casacore-1.5.0/casa/BasicMath/Math.h
300c300
< return ( std::isnan(val) );
---
> return ( isnan(val) );
diff -r ./casa/System/Casarc.cc ../orig/casacore-1.5.0/casa/System/Casarc.cc
37d36
< #include <unistd.h>


--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

[casa...@googlecode.com]

Comment #1 on issue 58 by nudomari...@gmail.com: Compiler errors with g++
4.7.2
http://code.google.com/p/casacore/issues/detail?id=58

I can confirm these errors and that the patch is working.

Apparently, there is also an alternative to this patch. New "#include
<unistd.h> lines can be added to casa/aips.h. and casa/System/Casarc.h
according to
http://lofarathamburg.wordpress.com/2013/01/11/things-needed-to-install-lofar-package/
I confirm that this other patch also works.

[casa...@googlecode.com]

Comment #2 on issue 58 by nicokrui...@gmail.com: Compiler errors with g++
4.7.2
http://code.google.com/p/casacore/issues/detail?id=58

Yes, sure. I guess that casa/aips.h is included in the other files. I tried
to keep the includes as local as possible. Either solution is fine with me.

[casa...@googlecode.com]

Comment #3 on issue 58 by hero...@gmail.com: Compiler errors with g++ 4.7.2
http://code.google.com/p/casacore/issues/detail?id=58

Perhaps it is duplicated to issue 51?

http://code.google.com/p/casacore/issues/detail?id=51

[casa...@googlecode.com]

Comment #4 on issue 58 by gervandi...@gmail.com: Compiler errors with g++
4.7.2
http://code.google.com/p/casacore/issues/detail?id=58

It is fixed on the trunk. A new release will be made soon by Malte.

[casa...@googlecode.com]

Comment #5 on issue 58 by Malte.Marquarding: Compiler errors with g++ 4.7.2
http://code.google.com/p/casacore/issues/detail?id=58

casacore-1.7.0 has been released. See the front page of the project.
casacore-2.0.0 will follow soon.

[casa...@googlecode.com]

Updates:
Status: Fixed
Owner: gervandi...@gmail.com

Comment #6 on issue 58 by gervandi...@gmail.com: Compiler errors with g++
4.7.2
https://code.google.com/p/casacore/issues/detail?id=58

(No comment was entered for this change.)