Best way to get process definition key from execution?

[galen...@gmail.com]

Hi,

I'm trying to find the best way to get a process definition key (i.e. the ACT_RE_PROCDEF.KEY_ valuue) from a DelegateExecution object.

++++++++++++++++++++++++++++++++++++++

String procDefKey = null;

List<DomElement> candEls = execution.getBpmnModelInstance().getDocument().getRootElement().getChildElements();

for (DomElement el : candEls) {
if (el.getLocalName().equals("process")) {
procDefKey = el.getAttribute("id");
break;
}
}

if (procDefKey == null) {
log.error("procDefKey not determined from model! ("+candEls.size() + " child els)");
for (DomElement el : candEls) {
log.warn("DomEl: localname = " + el.getLocalName());
}
}

++++++++++++++++++++++++++++++++++++

The above methodology seems to work, but once in a while (probably once out of every 5000 executions), the model only seems to have a "BPMNDiagram" element, and I get the following output:

++++++++++++++++++++++++++++++++++++++++

2015-04-02 10:07:54,203 ERROR ...( 268) - procDefKey not determined from model! (1 child els)
2015-04-02 10:07:54,204 WARN ...( 270) - DomEl: localname = BPMNDiagram

++++++++++++++++++++++++++++++++++++++++

So I have two questions:

1) Is there a more direct call I can use? I see execution.getProcessDefinitionId() and execution.getProcessBusinessKey(), but these are not the value I want...

2) Any explanation for the once-in-a-while incomplete model?


THanks,
Galen

[galen...@gmail.com]

By the way, I forgot to add that I'm trying to do this without hitting the database. I know there might be some QueryFor... things I can do, but I would prefer to remain in-memory.

[thorben....@camunda.com]

Hi Galen,

What about

BpmnModelInstance bpmnModelInstance = execution.getBpmnModelInstance();
Collection<Process> processElements = bpmnModelInstance.getModelElementsByType(org.camunda.bpm.model.bpmn.instance.Process.class);
String firstProcessKey = processElements.iterator().next().getAttributeValue("id");

Cheers,
Thorben

[thorben....@camunda.com]

Regarding your second question: Could you create a unit test?

Thanks,
Thorben

[thorben....@camunda.com]

Here's another, probably more robust way of getting the key:

RepositoryService repositoryService = execution.getProcessEngineServices().getRepositoryService();
ProcessDefinition definition = repositoryService.getProcessDefinition(execution.getProcessDefinitionId());
String processDefinitionKey = definition.getKey();

This will look up the process definition from the cache and not make an additional SQL query if the process definition has been resolved before which is should be the case when this code is executed within a JavaDelegate.

Cheers,
Thorben

[galen...@gmail.com]

Thanks Thorben for the solutions!
-- Galen

[Falko Menge]

Would'n't this work as well or are there moments when the process definition entity is not linked to the execution entity?

public class BusinessLoggingExecutionListener implements ExecutionListener {

  private final Logger LOGGER = Logger.getLogger(BusinessLoggingExecutionListener.class.getName());

  @Override

  public void notify(DelegateExecution execution) throws Exception {

    String processDefinitionKey = ((ProcessDefinitionEntity) ((ExecutionEntity) execution).getProcessDefinition()).getKey();

    LOGGER.info(processDefinitionKey + " - " + execution.getProcessBusinessKey() + " - " + execution.getEventName());

  }

}

[thorben....@camunda.com]

Hi Falko,

That should work as well but does not use API.

Cheers,
Thorben