On 5 January 2018 at 23:44, Will Norris <
wi...@willnorris.com> wrote:
>
> On Fri, Jan 5, 2018 at 2:22 PM, Mathieu Lonjaret
> <
mathieu....@gmail.com> wrote:
>>
>> I'm confused. Are you talking about what is now:
>>
>> domainNames = []string{"
perkeep.org", "
camlistore.org"}
>>
>> in website/godoc.go?
>>
>> (it became domainNames in 02938281318c8dc1fdb0e7a46b543fb7e583a854)
>>
>> As far as i can tell, we need the domain to:
>>
>> 1) verify that we're serving only for one of these two domains (which
>> might be overkill, as i think we already filter for that before
>> reaching this point)
>
>
> yeah, I think this is overkill. And also makes it a little harder to test
> this on localhost when developing :)
>
>>
>> 2) being able to strip it out of the path, and derive the part of the
>> import path that is a "filepath" (as opposed to a domain name).
>>
>> I think we're inheriting this second point from the logic of the go
>> stdlib godoc, since we copied the code from there and adapted it for
>> our needs afair.
>
>
> the stdlib godoc doesn't do anything with domains as best as I can tell,
ok, I don't really remember. it's old :)