tabs vs. spaces

[Jon Stevens]

I hate to bring up this silly flame war. But, I really want to clean up all the small warnings in this project, but I can't seems to get eclipse to write out spaces. I've noticed that the project already has a mix of tabs and spaces all over it. Would it be possible to just standardize on tabs? They are so much nicer than spaces.

jon

[erdincyilmazel]

No way! I hate tabs. There are no tabs in the source code right now. (Maybe some patches I have applied might have introduced a few). There is a problem with indentation though. Some files are indented with 3 spaces, some with 4. This happened by accident because I switched companies in between which had different coding standards and my IDE settings were different. I can apply source code formatting and make 4 spaces the standard in every source file.

Tabs? No. It is same asking you to switch to IntelliJ ;)

Erdinc

Sent from my iPad

[Jon Stevens]

ok, no problem. I've submitted an updated pull request that has spaces, fixes an issue with the jexl integration and resolves all eclipse compiler warnings. a few of which could be easily mitigated if your ide was setup to cleanup unused imports (why doesn't idea do that for you by default?).

jon