Application Indicator issues.

[Isaiah Heyer]

I have been working on making caffeine use an ApplicationIndicator
instead of a gtk.StatusIcon, and there are several issues I have run
into. First, somehow using AppInd makes the about dialog freeze when you
try to close it, and sub-menus are allowed, so no more "Activate For XYZ
minutes/hours".

We don't need to have an "Activate For..." option, and the AboutDialog
could be launched from the Preferences window.

What do you guys think? Should we go ahead and migrate to AppInd?

[Tommy Brunn]

You mean submenues aren't allowed? That's a shame, but honestly, I don't
think I've ever used the "activate for..." option. Either I activate it
manually or have it activate itself when a certain process is being run.

So yeah, migrate to AppInd if you can.

[Tommy Brunn]

I just wanted to let you guys know that I made some new icons to match
the new Ambiance and Radiance Ubuntu themes.

http://is.gd/bTEO7

Cheers!

[Brad Smith]

Wow! Those are really awesome.

[Isaiah H]

Cool, could you make some 24x24 png versions? Because the svgs scaled down aren't as "crisp" as they could be.

BTW, ApplicationIndicators only use installed icons instead of gtk.gdk.Pixbuf, so I am going to include these icons. So if the user is using the ubuntu-mono-dark or ubuntu-mono-light caffeine will use the correct icon. Any other icon theme and caffeine will use the old icon.

[Tommy Brunn]

Sure. I'll make a couple of different png versions. I'll let you know
once I have them.

[Tommy Brunn]

Alright, I've got all the icons in their various sizes and colors. I
made 16-48 + scalable.

http://dl.dropbox.com/u/176093/Caffeine-icons-2.tar.gz

On Tue, 2010-05-04 at 14:07 -0500, Isaiah H wrote:

[Isaiah H]

Thanks, but there are some problems with those. The 22x22 and 32x32 full cup icons aren't the correct size and the and pretty much all of full cup icons are blurry and require some editing to make them look sharper.

[Tommy Brunn]

Oops, I'll fix those size issues in a bit. As for the blurriness, that's
something that will have to be fixed over time - as I would have to
manually make a new set of icons for each size, and that takes a lot of
time and effort. I'll see what I can do when I get home from university.

Which sizes are the most important that we get right? So I know which
ones I should start with. 22 and 32?

[Isaiah H]

With the default panel size, the 22 icons are used. So 22 is most important.

[Tommy Brunn]

Alright. I manually remade every single icon and fixed some color
issues. This is really the best I can do, so I hope they'll do.

http://dl.dropbox.com/u/176093/Caffeine-icons-3.tar.gz

[Isaiah H]

Perfect! I have uploaded a package with these icons to the dev ppa. https://edge.launchpad.net/~caffeine-developers/+archive/caffeine-dev/+packages

[Tommy Brunn]

Great, but I think think the build failed. I skimmed through the log,
and it seems like the scalable icons were incorrectly named.

[Isaiah H]

Ok, got that fixed and the package has been built.

[Tommy Brunn]

Great! Got it installed, and it seems to be working fine. Annoying not
to have the tooltips though, to see what activated Caffeine. Do you
think it would be useful to add a line to the menu (can you even do
that?) that says what activated Caffeine if it was automatically
activated? Or is that unnecessary?

[Tommy Brunn]

Just noticed one more thing. Despite me using the ubuntu_mono_dark
icons, the only icon that is changed is the one being displayed as an
indicator. The one in the about dialog, the one in the window list (when
you open the preferences), the one in the list of processes running, and
the one in the application menu are all the old icon. Shouldn't those
also be set to the new icon if that icon theme is being used?

On Thu, 2010-05-06 at 19:35 -0500, Isaiah H wrote:

[Isaiah H]

I did that on purpose because black and white icons can cause problems depending on what theme the user is using or if they are using a dock. Also, I think that the old icon and the new ones look different enough that it might make it harder to find caffeine in the menu. Plus it really wouldn't fit in with any of the other icons in the application menu.

[Tommy Brunn]

Yeah, I think you're right. Lets stick with the original icon for those
things.

[Tommy Brunn]

I just realized that the new icons aren't being placed in the right
directories. They should be placed
in /usr/share/icons/ubuntu_mono_(dark/light)/apps/$size/
Right now they are being placed
in /usr/share/icons/ubuntu_mono_(dark/light)/$size

Take a look in /usr/share/icons/ubuntu_mono(dark/light)/ and you'll see
what I mean.