possible bug in cactus_setup.c?

1 view
Skip to first unread message

Leo Goodstadt

unread,
May 16, 2013, 10:10:41 AM5/16/13
to cactu...@googlegroups.com
Dear Dr. Paten,

Reading the code in cactus, sequence file names apparently can be provided either as "xxx.complete" or "xxx.complete.fa" but the later doesn't seem to work:

in cactus_setup.c:100, we see code designed to pull out the matching path suffix . This works for ".complete" which is 9 chars but not for ".complete.fa" which is 12 chars rather than 11. 


I.e. 
    if (i >= 11) {
        const char *cA = fileName + i - 11;
        if (strcmp(cA, ".complete.fa") == 0) {

Should be:
    if (i >= 12) {
        const char *cA = fileName + i - 12;
        if (strcmp(cA, ".complete.fa") == 0) {


Leo

Benedict Paten

unread,
May 16, 2013, 8:16:25 PM5/16/13
to cactu...@googlegroups.com
Oops, thanks, that's embarrassing! I've pushed a fix on the development branch. Will  I'm not sure anyone is using that feature, though. 



Leo

--
You received this message because you are subscribed to the Google Groups "cactus" group.
To unsubscribe from this group and stop receiving emails from it, send an email to cactusUsers...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
 
 

Reply all
Reply to author
Forward
0 new messages