[PATCH] Fixed failing test cases due to missing REMOTE_ADDR in post, and notification/registration emails being sent

0 views
Skip to first unread message

Greg Heartsfield

unread,
May 26, 2008, 7:01:15 PM5/26/08
to byteflow...@googlegroups.com
# HG changeset patch
# User Greg Heartsfield <scs...@imap.cc>
# Date 1211842608 18000
# Node ID 459e0048b9cd68e813054161307d0baf1f801d75
# Parent 748541295821bb73403881be779f586496e969b3
Fixed failing test cases due to missing REMOTE_ADDR in post, and notification/registration emails being sent

diff -r 748541295821 -r 459e0048b9cd apps/blog/tests.py
--- a/apps/blog/tests.py Mon May 26 14:43:44 2008 -0500
+++ b/apps/blog/tests.py Mon May 26 17:56:48 2008 -0500
@@ -51,7 +51,8 @@
self.comments = CommentNode.all_objects.for_object(self.p1)
self.assertEquals(len(self.comments), 1)
self.assertEquals(comment_text, self.comments[0].body)
- self.assertEquals(len(mail.outbox), 1)
+ # Expect a registration and notification email to be sent
+ self.assertEquals(len(mail.outbox), 2)

def testDeleteComments(self):
c = CommentNode(approved=False, body="just test", user=self.user, object=self.p1)
diff -r 748541295821 -r 459e0048b9cd apps/blog/views.py
--- a/apps/blog/views.py Mon May 26 14:43:44 2008 -0500
+++ b/apps/blog/views.py Mon May 26 17:56:48 2008 -0500
@@ -63,7 +63,7 @@
post = get_object_or_404(Post.all_objects.filter(date__range=today), slug=slug)
if post.comments_open():
Form = request.user.is_authenticated() and CommentForm or AnonymousCommentForm
- form = build_form(Form, request, remote_ip=request.META['REMOTE_ADDR'], post=post, user=request.user,
+ form = build_form(Form, request, remote_ip=request.META.get('REMOTE_ADDR'), post=post, user=request.user,
initial={'reply_to': reply_to})
if form.is_valid():
c, user_is_new = form.save()

Reply all
Reply to author
Forward
0 new messages