Patch to get Ivy module description from Bundle-Description

1 view
Skip to first unread message

15 knots

unread,
Aug 20, 2009, 8:18:49 AM8/20/09
to bushe...@googlegroups.com
Hi,
attached is a patch to get Ivy module description from Bundle-Description.

Regards, Martin

bushel.patch

Alex Radeski

unread,
Aug 20, 2009, 4:49:23 PM8/20/09
to bushe...@googlegroups.com
Hi Martin,

Thanks for submitting the patch. I'll take a look at it over the
weekend and see if we can integrate it.

Cheers,
Alex

alexr

unread,
Aug 21, 2009, 5:33:02 AM8/21/09
to bushel-user
Also it would be good if the patch was accompanied by a unit test :-)

On Aug 20, 9:49 pm, Alex Radeski <a...@radeski.net> wrote:
> Hi Martin,
>
> Thanks for submitting the patch. I'll take a look at it over the
> weekend and see if we can integrate it.
>
> Cheers,
> Alex
>

15 knots

unread,
Aug 21, 2009, 8:10:10 AM8/21/09
to bushe...@googlegroups.com
2009/8/21 alexr <alex.r...@googlemail.com>:

>
> Also it would be good if the patch was accompanied by a unit test :-)

Sure. Some tests are attached, but I did not tests these. (For the
moment, I'm too lazy to dig deeply into the bushel testing code).

Martin

testcases.patch

alexr

unread,
Aug 23, 2009, 1:00:36 PM8/23/09
to bushel-user
I've taken a look at your patch. I couldn't apply it as it was, but
you can see the changes I've made here to add description support :
http://code.google.com/p/bushel/source/detail?r=115

On Aug 21, 1:10 pm, 15 knots <fifteenknots...@googlemail.com> wrote:
> 2009/8/21 alexr <alex.rade...@googlemail.com>:
>
>
>
> > Also it would be good if the patch was accompanied by a unit test :-)
>
> Sure. Some tests are attached, but I did not tests these. (For the
> moment, I'm too lazy to dig deeply into the bushel testing code).
>
> Martin
>
>  testcases.patch
> 12KViewDownload

15 knots

unread,
Aug 24, 2009, 6:28:21 AM8/24/09
to bushe...@googlegroups.com
Hi Alex,

I had a look at it
<http://code.google.com/p/bushel/source/detail?r=115> but I could not
find the 'tricky part': How to read the description from a
properties-file inside the jar if it is externalized (i.e. the
Manifest-header value starts with a percent sign).

But i guess the integration into BushelManifestParser is not as easy
as I did with with OsgiManifestParser.

Martin

alexr

unread,
Aug 24, 2009, 9:14:33 AM8/24/09
to bushel-user
I'll take another look at the externalised part soon. First step was
to just preserve the description in the Ivy repo. I haven't look at
the externalised string support in the OSGi spec, if you have any
references to documentation it would be handy.

Alex

15 knots

unread,
Aug 24, 2009, 12:24:58 PM8/24/09
to bushe...@googlegroups.com
Hi alex,

> to just preserve the description in the Ivy repo. I haven't look at
> the externalised string support in the OSGi spec, if you have any
> references to documentation it would be handy.

You can find it in 'OSGi Service Platform Core Specification', chapter
3.10 Localization.
The above PDF can be downloaded at osgi.org

Martin

Reply all
Reply to author
Forward
0 new messages