[PATCH 1/5] test_bloom: write bup.bloom to tmpdir, not ./

[Rob Browning]

Signed-off-by: Rob Browning <r...@defaultvalue.org>
Tested-by: Rob Browning <r...@defaultvalue.org>
---
test/int/test_bloom.py | 1 +
1 file changed, 1 insertion(+)

diff --git a/test/int/test_bloom.py b/test/int/test_bloom.py
index 2c59269b..43479285 100644
--- a/test/int/test_bloom.py
+++ b/test/int/test_bloom.py
@@ -30,6 +30,7 @@ def test_bloom(tmpdir):
assert false_positives < 10
os.unlink(tmpdir + b'/pybuptest.bloom')

+ os.chdir(tmpdir)
with BloomWriter(b'bup.bloom', 'w+b', expected=100) as b:
assert b.path == b'bup.bloom'
assert b.k == 5
--
2.47.3

[Rob Browning]

Overlooked when restoring support on affected big endian hosts here:

20a5752021769c3fab183f2646662bdf1b6083fc
Reallow linux attrs on big endian hosts where long > int

Signed-off-by: Rob Browning <r...@defaultvalue.org>
---
Documentation/bup-index.1.md | 17 ++++++++---------
1 file changed, 8 insertions(+), 9 deletions(-)

diff --git a/Documentation/bup-index.1.md b/Documentation/bup-index.1.md
index c7350b1d..328ce811 100644
--- a/Documentation/bup-index.1.md
+++ b/Documentation/bup-index.1.md
@@ -41,15 +41,6 @@ need the same information).

# NOTES

-At the moment, bup will ignore Linux attributes (cf. chattr(1) and
-lsattr(1)) on some systems (any big-endian systems where sizeof(long)
-< sizeof(int)). This is because the Linux kernel and FUSE currently
-disagree over the type of the attr system call arguments, and so on
-big-endian systems there's no way to get the results without the risk
-of stack corruption (http://lwn.net/Articles/575846/). In these
-situations, bup will print a warning the first time Linux attrs are
-relevant during any index/save/restore operation.
-
bup makes accommodations for the expected "worst-case" filesystem
timestamp resolution -- currently one second; examples include VFAT,
ext2, ext3, small ext4, etc. Since bup cannot know the filesystem
@@ -85,6 +76,14 @@ first index run):
Strictly speaking, bup should not notice the change to src/2, but it
does, due to the accommodations described above.

+Previously bup would ignore Linux attributes (cf. chattr(1) and
+lsattr(1)) on big-endian systems where sizeof(long) < sizeof(int).
+This was because the Linux kernel and FUSE disagreed over the type of
+the attr system call arguments, (http://lwn.net/Articles/575846/).
+Since the kernel fixed the problem in 2020, bup now attempts to handle
+them everywhere, while still being careful not to corrupt the stack in
+the unlikely case the current system doesn't have the fix.
+
# MODES

-u, \--update
--
2.47.3

[Rob Browning]

Just some fairly simple fixes.

Pushed to main.

--
Rob Browning
rlb @defaultvalue.org and @debian.org
GPG as of 2011-07-10 E6A9 DA3C C9FD 1FF8 C676 D2C4 C0F0 39E9 ED1B 597A
GPG as of 2002-11-03 14DD 432F AE39 534D B592 F9A0 25C8 D377 8C7E 73A4

[Rob Browning]

Signed-off-by: Rob Browning <r...@defaultvalue.org>
Tested-by: Rob Browning <r...@defaultvalue.org>
---

lib/bup/_helpers.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/bup/_helpers.c b/lib/bup/_helpers.c
index 81a74a26..0d810335 100644
--- a/lib/bup/_helpers.c
+++ b/lib/bup/_helpers.c
@@ -1767,7 +1767,7 @@ bup_readline(PyObject *self, PyObject *args)
return NULL;
char *line = readline(prompt);
if (!line)
- return Py_None;
+ Py_RETURN_NONE;
PyObject *result = PyBytes_FromString(line);
free(line);
return result;
--
2.47.3