[PATCH 3/3] test-sparse-files: increase the test size for macos/afs

2 views
Skip to first unread message

Rob Browning

unread,
Jul 11, 2022, 2:29:22 PM7/11/22
to bup-...@googlegroups.com
When the cirrus tests moved to monterey test-sparse-files started
failing in "sparse file restore --sparse (sparse middle)" because the
restore_size was 28 and so greater than the expected 20.

Guessing that this might just be due to higher fixed-costs, I doubled
the sparse region data_size, and that did allow the tests to pass.
While the diagnosis might or might not be correct, the change
shouldn't materially affect the tests' effectiveness.

Signed-off-by: Rob Browning <r...@defaultvalue.org>
Tested-by: Rob Browning <r...@defaultvalue.org>
---
test/ext/test-sparse-files | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/test/ext/test-sparse-files b/test/ext/test-sparse-files
index d19bf181..2bfd1876 100755
--- a/test/ext/test-sparse-files
+++ b/test/ext/test-sparse-files
@@ -21,7 +21,7 @@ WVPASS cd "$tmpdir"
block_size=$(bup-cfg-py -c \
"import os; print(getattr(os.stat('.'), 'st_blksize', 0)) or $mb * 3") \
|| exit $?
-data_size=$((block_size * 10))
+data_size=$((block_size * 20))
readonly block_size data_size

WVPASS dd if=/dev/zero of=test-sparse-probe seek="$data_size" bs=1 count=1
--
2.30.2

Reply all
Reply to author
Forward
0 new messages