[PATCH 01/12] Accommodate and enable pylint arguments-differ

0 views
Skip to first unread message

Rob Browning

unread,
Mar 6, 2026, 6:16:52 PM (8 days ago) Mar 6
to bup-...@googlegroups.com
Remove the finish_writing() run_midx argument; it doesn't look like
it's ever been used.

Signed-off-by: Rob Browning <r...@defaultvalue.org>
Tested-by: Rob Browning <r...@defaultvalue.org>
---
.pylintrc | 1 +
lib/bup/repo/base.py | 4 ++--
lib/bup/repo/remote.py | 2 +-
3 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/.pylintrc b/.pylintrc
index bda2a958..8af9bc45 100644
--- a/.pylintrc
+++ b/.pylintrc
@@ -4,6 +4,7 @@
[MESSAGES CONTROL]
disable=all
enable=
+ arguments-differ,
assert-on-string-literal,
assignment-from-no-return,
bad-classmethod-argument,
diff --git a/lib/bup/repo/base.py b/lib/bup/repo/base.py
index c55dba87..1849f33b 100644
--- a/lib/bup/repo/base.py
+++ b/lib/bup/repo/base.py
@@ -44,7 +44,7 @@ class RepoProtocol:
"""..."""

@notimplemented
- def config_get(self, name, opttype=None):
+ def config_get(self, name, *, opttype=None):
"""
Return the configuration value of 'name', returning None if it doesn't
exist. opttype indicates the type of option.
@@ -141,7 +141,7 @@ class RepoProtocol:
"""

@notimplemented
- def finish_writing(self, run_midx=True):
+ def finish_writing(self):
"""
Finish writing, i.e. really add the previously tentatively written
objects to the repository.
diff --git a/lib/bup/repo/remote.py b/lib/bup/repo/remote.py
index 9f841a91..44af1ddb 100644
--- a/lib/bup/repo/remote.py
+++ b/lib/bup/repo/remote.py
@@ -108,7 +108,7 @@ class RemoteRepo(RepoProtocol):
self._ensure_packwriter()
return self._packwriter.exists(sha, want_source=want_source)

- def finish_writing(self, run_midx=True):
+ def finish_writing(self):
if self._packwriter:
w = self._packwriter
self._packwriter = None
--
2.47.3

Reply all
Reply to author
Forward
0 new messages