Please pull some fixes

[Niklaus Giger]

Hi Antoine.

Can you look at my fork at github.org? Please look at the following commits.
They are mainly some small fixes for problems.

Fixes problems when requesting version where we find only a newer/higher
version
https://github.com/ngiger/buildr4osgi/commit/0228da8fc90ab1e7e84780bb45b7e9673606d38a

Fragment handling improved. A fragment introduces a dependency to the host
plugin
https://github.com/ngiger/buildr4osgi/commit/da6fe7e82a734ba81873631094bcd78d010e1f40

Use OSGi if you find a publisher there
https://github.com/ngiger/buildr4osgi/commit/28b54b56ac5479b71a3652434ef59187194ac1f5

Improved with this patch, by allowing to specify a P2_EXE via an environment
variable.
Using variable OSGi fails if it points to an p2 mirror and not an ecl…
https://github.com/ngiger/buildr4osgi/commit/afa2d0452f5c8a2119b15439d5c2edda9ea17283

https://github.com/ngiger/buildr4osgi/commit/d9ef5ce7a075b18dc81934df5bd5659d4716da17
Adresses three points:
- Fail if no P2-launcher found
- use project.path_to(:target), instead of fixed coded
File.join(project.base_dir, "target"
- Use -append (worked more reliably with Eclipse Helios)

I would appreciate if you could comment and/or merge these fixes. I have not
added any specs, as running them failed.

I would like to apologize that my fixes are probably not suited to pull them
in like this, as they sometimes also change the buildr4osgi version. Next time
I will try to do better.

Best regards

Niklaus

[Antoine Toulme]

I will. I will also consider giving you commit rights and let you push
to rubygems :)

[Niklaus Giger]

Hi Antoine

> I will. I will also consider giving you commit rights and let you push
> to rubygems :)

Thanks for the honour! But I must confess, that I do not feel comfortable in
all part of buildr4osgi.

Must the subfolder buildr inside buildr4osgi contain a fixed version of
buildr? And what happens with the patches that are present in newer version of
buildr?

Why don't we use in this case subrepository to be able to easier track buildr?

And can you give me any hints how I can bring the spec to run again. I feel
bad if I cannot show my changes to work.

Best regards

Niklaus

>
> On Apr 13, 2012, at 8:13, Niklaus Giger <niklau...@member.fsf.org>
wrote:
> > Hi Antoine.
> >
> > Can you look at my fork at github.org? Please look at the following
> > commits. They are mainly some small fixes for problems.
> >
> > Fixes problems when requesting version where we find only a newer/higher
> > version
> > https://github.com/ngiger/buildr4osgi/commit/0228da8fc90ab1e7e84780bb45b7
> > e9673606d38a
> >
> > Fragment handling improved. A fragment introduces a dependency to the
> > host plugin
> > https://github.com/ngiger/buildr4osgi/commit/da6fe7e82a734ba81873631094bc
> > d78d010e1f40
> >
> > Use OSGi if you find a publisher there
> > https://github.com/ngiger/buildr4osgi/commit/28b54b56ac5479b71a3652434ef5
> > 9187194ac1f5
> >
> > Improved with this patch, by allowing to specify a P2_EXE via an
> > environment variable.
> > Using variable OSGi fails if it points to an p2 mirror and not an ecl…
> > https://github.com/ngiger/buildr4osgi/commit/afa2d0452f5c8a2119b15439d5c2
> > edda9ea17283
> >
> > https://github.com/ngiger/buildr4osgi/commit/d9ef5ce7a075b18dc81934df5bd5

> > 659d4716da17 Adresses three points:

> > - Fail if no P2-launcher found
> > - use project.path_to(:target), instead of fixed coded
> > File.join(project.base_dir, "target"
> > - Use -append (worked more reliably with Eclipse Helios)
> >
> > I would appreciate if you could comment and/or merge these fixes. I have
> > not added any specs, as running them failed.
> >
> > I would like to apologize that my fixes are probably not suited to pull
> > them in like this, as they sometimes also change the buildr4osgi
> > version. Next time I will try to do better.
> >
> >
> > Best regards
> >
> > Niklaus

--
Niklaus Giger