buildr4osgi does not compare correctly '2.0.9' to '2.0.14'

4 views
Skip to first unread message

Niklaus Giger

unread,
Jul 18, 2012, 1:18:41 PM7/18/12
to build...@googlegroups.com
Hi Antoine

3 of over 170 Eclipse projects did not correctly resolve. After digging into
the buildr4osgi code I think I found the error.

Please have a look at the attached patch (includes a test).

Creating a soft link buildr to a current checkout of buildr (slightly patched
because of https://issues.apache.org/jira/browse/BUILDR-647) and a small patch
in spec/spec_helpers.rb
> index fd55241..1a56630 100644
> --- a/spec/spec_helpers.rb
> +++ b/spec/spec_helpers.rb
> @@ -20,7 +20,7 @@ unless defined?(SpecHelpers)
>
> def SandboxHook.included(spec_helpers)
>
> # For testing we use the gem requirements specified on the
> buildr4osgi.gemspec spec =
> Gem::Specification.load(File.expand_path('../buildr4osgi.gemspec',
> File.dirname(__FILE__)))
>
> - spec.dependencies.each { |dep| gem dep.name,
> dep.version_requirements.to_s } +# spec.dependencies.each { |dep| gem
> dep.name, dep.version_requirements.to_s }
>
> # Make sure to load from these paths first, we don't want to load
> any # code from Gem library.
> $LOAD_PATH.unshift File.expand_path('../lib',
> File.dirname(__FILE__))
allowed me to run "rspec spec/osgi/version_spec.rb".

Running rspec still yields 54 failures.


Best regards

--
Niklaus Giger
bug_version_resolution.diff
Reply all
Reply to author
Forward
0 new messages