Menu Plugin - ClassCastException: brix.plugin.menu.editor.MenuTreeNode

[James McIntosh]

I'm seeing the following stack when trying to add a new menu item
after upgrading to wicket 1.4.12.

Is anyone else seeing this issue or diagnosed it yet?

java.lang.ClassCastException: brix.plugin.menu.editor.MenuTreeNode
cannot be cast to javax.swing.tree.TreeNode
at
org.apache.wicket.markup.html.tree.AbstractTree.treeNodesInserted(AbstractTree.java:
823)
at
brix.web.tree.AbstractTreeModel.nodeInserted(AbstractTreeModel.java:
138)
at brix.plugin.menu.editor.MenuEditor$5.onClick(MenuEditor.java:194)
at org.apache.wicket.ajax.markup.html.AjaxLink
$1.onEvent(AjaxLink.java:68)
at
org.apache.wicket.ajax.AjaxEventBehavior.respond(AjaxEventBehavior.java:
177)
at
org.apache.wicket.ajax.AbstractDefaultAjaxBehavior.onRequest(AbstractDefaultAjaxBehavior.java:
300)
at
org.apache.wicket.request.target.component.listener.BehaviorRequestTarget.processEvents(BehaviorRequestTarget.java:
119)

[Korbinian]

what version ob Brix you are on?

[Brian Topping]

Could unit tests be developed for these?

> --
> You received this message because you are subscribed to the Google Groups "brix-cms-discuss" group.
> To post to this group, send email to brix-cms...@googlegroups.com.
> To unsubscribe from this group, send email to brix-cms-discu...@googlegroups.com.
> For more options, visit this group at http://groups.google.com/group/brix-cms-discuss?hl=en.
>

[James McIntosh]

brix version 1.2.2

[Korbinian]

I found the problem: WICKET-2886 is the one!

It breaks everything that expects a Model holding a TreeNode as a
Swing TreeNode is now used explicitly, see patch lines:
...
+import javax.swing.tree.TreeNode;
...
// get the parent node of inserted nodes
- Object parent = e.getTreePath().getLastPathComponent();
+ TreeNode parentNode =
(TreeNode)e.getTreePath().getLastPathComponent();

- if (isNodeVisible(parent) && isNodeExpanded(parent))
+ if (isNodeVisible(parentNode))
{

....

IMHO wicket 1.4 should revert the patch as it will break all Tree's
out there that expect the old Object parent and not the TreeNode from
Swing;

Any comments?

[James McIntosh]

I agree with it not expecting a TreeNode but more careful
consideration of the new bug and a re-implementation of the previous
patch is the proper course of action rather than just reverting the
patch. I say this because the build has been released, this can't be
taken back and there was a reason for this path, another bug which
still needs to be addressed.

I'll have a look at it over this weekend in more depth as I have a
couple of other components which also have custom trees in other
wicket projects which will also be affected upon moving to the new
wicket versions.

James

[danisevsky]

Could I ask you what is the status of this bug? Is it reported to the
wicket jira?