Notifying event organizers that there event has been approved?

10 views
Skip to first unread message

Tyler B

unread,
Jul 28, 2015, 4:54:23 PM7/28/15
to Bridge Troll
Hey,

So I'm not entirely sure, but from my local environment I'm not seeing anywhere that event organizers are being notified that their event was approved. My process is to, as an Admin, create an event with the "send announcement to chapter when event is approved" unchecked. Then, I navigate to /events/unpublished_events and click "publish," only to be notified that "Are you sure? This will email 0 members of RailsBridge San Francisco." Indeed, no emails are sent according to my console.

It seems important that if an event organizer does not want their announcement email to be sent at the time of approval but at some other time (a feature I am hoping to build) or never, they should be notified when they get their event approved.

The code seems to support this hypothesis as well. Inside "event_mailer.rb" the "new_event" method only sends emails by:

set_recipients(User.joins(:chapters).where('users.allow_event_email = ?', true).where('chapters.id' => [@chapter.id]).map(&:email))

basically, by chapters. The "unpublished_event_controller.rb" uses this same "event_mailer" action to send emails once an email is published. A possible fix would be to do some mixture of "event_mailer"'s "new_event" and "unpublished_event" methods.

Am I approving events correctly? Should I go ahead and "fix" publishing new events to notify the admin that they have had there event approved? 

Katherine

unread,
Jul 28, 2015, 8:37:16 PM7/28/15
to Bridge Troll, tylerbr...@gmail.com
> So I'm not entirely sure, but from my local environment I'm not seeing anywhere that event organizers are being notified that their event was approved.

As a non-admin user of bridgetroll.org, I can see that my events have been approved in a few ways:
  • when I'm not logged, the event does not show up on the bridgetroll.org or bridgetroll.org/events page
  • when I am logged in, after I 'Submit Event for Approval,' I can see the event card on the bridgetroll.org or bridgetroll.org/events page, but it is slightly greyed out, lighter than the published events.
  • when I attempt to add a co-Organizer, I'll get an error message if the event hasn't been published yet

Not that this impacts what you're doing, but that's how I've seen that non-admin can see unpublished vs published.


Katherine

Sameer Siruguri

unread,
Jul 28, 2015, 8:49:01 PM7/28/15
to Katherine, Bridge Troll, tylerbr...@gmail.com
I found the e-mail explanation a little hard to parse but I think what you're getting at is this story -

AS AN Organizer of an event, WHEN my event is approved by an Admin, I WANT TO receive an email telling me that happened.

If that's what you are after, then +1.


--
You received this message because you are subscribed to the Google Groups "Bridge Troll" group.
To unsubscribe from this group and stop receiving emails from it, send an email to bridge-troll...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Katherine

unread,
Jul 28, 2015, 9:08:12 PM7/28/15
to Bridge Troll, tylerbr...@gmail.com, siru...@gmail.com
Sorry, Sameer, I'm just describing the status quo, not making feature requests.

I know that he is working on (and you want) positive notification in the form of an email.

Sameer Siruguri

unread,
Jul 28, 2015, 9:11:09 PM7/28/15
to Katherine, Bridge Troll, tylerbr...@gmail.com
Oops, sorry, my reference was to Tyler's email, not yours - that wasn't clear I think. I agree with your description of how organizers find out when their events are approved - that's pretty my SOP too.


Tyler B

unread,
Jul 29, 2015, 12:12:31 AM7/29/15
to Sameer Siruguri, Katherine, Bridge Troll
AS AN Organizer of an event, WHEN my event is approved by an Admin, I WANT TO receive an email telling me that happened.

Yea, that is what I want to have happen. Just to clarify my wall of text, what currently happens is:

WHEN any event is approved by an Admin, AND the announcement checkbox was checked during the creation of the event, THEN all people subscribed to the chapter get notified.

So, the Organizer would never be notified via email in the case that announcement checkbox was NOT checked. They could check event approval themselves by doing what Katherine suggested, but that does not seem as nice as notifying the Organizer via email.

Sincerely,

Tyler Brothers

Reply all
Reply to author
Forward
0 new messages