seeking Bridge Troll contributors!

22 views
Skip to first unread message

Sarah Allen

unread,
Jan 19, 2019, 4:37:45 PM1/19/19
to bridge...@googlegroups.com
Hi Bridge Troll fans,

I'm hoping there are some folks on this list who are willing to help -- either by chipping in on some short term needs or helping out with some projects and creating a more sustainable contributor group:
  1. short-term: review open PRs -- there are quite a few open PRs. I'd like to honor those contributions, but some may be out of date -- this could be solo or pairing
  2. mentor a volunteer intern this summer!  help define a project, periodical check-ins, etc. (see below)
  3. join a small team of core contributors who will be more responsive to reviewing PRs and responding to issues
Please reply, if you might be available in helping in any way, or if you have questions or ideas about how we can create a more sustainable, on-going effort on Bridge Troll.

Thank you!
Sarah


Summer Internship 
We have an inquiry from a Brown University student who is working on getting computer science students involved with non-profits.  

To get Brown computer science students involved with your work, we were thinking we could accommodate you in hosting one or multiple virtual "info sessions" where someone from the Bridge Foundry could talk about the work you're doing, and more specifically, technical challenges that a freshman or sophomore computer science student could help you tackle over a summer internship — whether that be updating/maintaining a database or redoing a website.

Jason Hsu

unread,
Jan 19, 2019, 7:04:40 PM1/19/19
to Bridge Troll
I'd like to help with the Bridge Troll web site.

Sarah Allen

unread,
Jan 20, 2019, 3:27:38 PM1/20/19
to Jason Hsu, Bridge Troll
Hi Jason,

It looks #580 was part of some UI improvements that were being worked on last year.  It looks like there are some small, yet valuable, content/navigation improvements.  It would be great to have a screenshot of the new footer, so folks who aren't active in the code could review the new footer before merging.

Would you be able to sync that locally and resolve merge conflicts?  and then post a screenshot or two of content changes for review?

Thank you!
Sarah

On Sat, Jan 19, 2019 at 4:04 PM Jason Hsu <jhsu8...@gmail.com> wrote:
I'd like to help with the Bridge Troll web site.

--
You received this message because you are subscribed to the Google Groups "Bridge Troll" group.
To unsubscribe from this group and stop receiving emails from it, send an email to bridge-troll...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Sameer Siruguri

unread,
Jan 20, 2019, 8:53:18 PM1/20/19
to Sarah Allen, bridge...@googlegroups.com
I would be interested in being a mentor, or reviewer. In the near future, I won't have time to commit to coding but maybe later in the summer...


--

Jason Hsu

unread,
Jan 21, 2019, 10:07:09 AM1/21/19
to Bridge Troll
On Sunday, January 20, 2019 at 2:27:38 PM UTC-6, Sarah Allen wrote:
Hi Jason,

It looks #580 was part of some UI improvements that were being worked on last year.  It looks like there are some small, yet valuable, content/navigation improvements.  It would be great to have a screenshot of the new footer, so folks who aren't active in the code could review the new footer before merging.

Would you be able to sync that locally and resolve merge conflicts?  and then post a screenshot or two of content changes for review?

Yes, I can look at that, sync it, and post screenshots.

When I work on a Rails app, there are a lot of elements that I find necessary but most other people don't.  They include Bash scripts for routine tasks, the bundler-audit/brakeman/gemsurance gems, and the rails-erd/railroady gems.  Do you want me to submit these elements in pull requests, or should I just keep them in my own personal branch?  (I can use the "git cherry-pick" command to get the benefit if my special "Ruby on Racetracks" elements while keeping them out of pull requests.)

Asheesh Laroia

unread,
Jan 21, 2019, 5:31:18 PM1/21/19
to Jason Hsu, Bridge Troll
My preference personally, as a random bystander, is to have nice scripts like that in the repo.

--

Sarah Allen

unread,
Jan 21, 2019, 8:05:20 PM1/21/19
to Asheesh Laroia, Jason Hsu, Bridge Troll
I agree.  Checkout bin/setup which is a nice script that makes sure the dependencies are installed.  You could add useful scripts to the bin directory -- just submit each logical unit as an individual PRs so folks can chime in on particular workflow improvements.

Thank you!
Sarah

Sarah Allen

unread,
Jan 21, 2019, 10:15:23 PM1/21/19
to Sameer Siruguri, Bridge Troll
Hi Sameer,

Thanks you for volunteering as reviewer and mentor. If you have time in the next few weeks to take a look at any of the open PRs and give feedback or +1, that would be great.  I think it was Travis' idea that if we could get a few people reviewing PRs, then its easier to grow the team of committers. 

Jane (@careful-with-that-axe) and I are also going to reach out to some folks who have contributed before and may not be on this list.  If we can get a small group who regularly reviews PRs into a bit a rhythm before the summer, then I think we could be in a good place to have an intern and others make more substantial contributions.

Thank you!
Sarah

  
Message has been deleted

Jason Hsu

unread,
Jan 22, 2019, 4:54:58 PM1/22/19
to Bridge Troll
I'm trying to set up my local development environment, but one of the tests keeps failing.  More details are at https://github.com/railsbridge/bridge_troll/issues/599.

Asheesh Laroia

unread,
Jan 23, 2019, 12:44:06 AM1/23/19
to Jason Hsu, Bridge Troll
Hi there! I recommend you ignore this issue for now. Later on, we can all work together to get it fixed.

Happy to explain the issue if that helps.

--

Sameer Siruguri

unread,
Jan 23, 2019, 12:47:00 PM1/23/19
to Asheesh Laroia, Jason Hsu, Bridge Troll
Couldn't the tests just ignore the JS error, or set up a webmock to stub responses to external requests? The map itself isn't required to be returned for a test to pass, is it?

Asheesh Laroia

unread,
Jan 24, 2019, 8:19:52 PM1/24/19
to Sameer Siruguri, Jason Hsu, Bridge Troll
I haven't checked in depth, but what you're saying sounds good to me!

Jason Hsu

unread,
Jan 28, 2019, 5:38:39 PM1/28/19
to Bridge Troll
I posted the screenshot in a comment I added to the pull request.

How do I update somebody else's branch in a fork?  I'm used to working with my own fork, not somebody else's.

Rachel Ober

unread,
Jan 28, 2019, 10:32:51 PM1/28/19
to Bridge Troll
Depending on if the other person is active, you might be better off creating a new branch and cherry-picking their commit from their fork and then adding any necessary commits to fix up their branch. That way, that person can continue to have credit for their work.


Rachel Ober
photoPhone: (724) 256-3955
Email: rache...@gmail.com
Website: https://www.rachelober.com
Schedule: https://bookme.name/rachelober


On Mon, Jan 28, 2019 at 5:38 PM Jason Hsu <jhsu8...@gmail.com> wrote:
I posted the screenshot in a comment I added to the pull request.

How do I update somebody else's branch in a fork?  I'm used to working with my own fork, not somebody else's.

--

Jason Hsu

unread,
Mar 21, 2019, 5:19:59 PM3/21/19
to Bridge Troll
We need more collaborators.  I don't know how many there are, but I understand that people are busy with things other than Bridge Troll.  Having more collaborators increases the chances that someone can review pull requests and merge them if they check out.

There are several recent pull requests waiting to be merged.  If I were a collaborator, I wouldn't hesitate to merge pull request #628, which simply fixes a header in the README file.  Those of you who use MacOS for your development environment should have an easy time reviewing pull request #620, which simply updates the procedure for installing phantomjs in MacOS.

I've submitted some simple pull requests as well that are still waiting for review.  I'm becoming more selective about the projects I delve into.  I'd rather get involved in projects that are frequently updated, because that gives me assurance that my pull requests will be reviewed and accepted (or promptly rejected) rather than left stagnating.

Sarah Allen

unread,
Mar 22, 2019, 10:57:41 AM3/22/19
to Jason Hsu, Bridge Troll
Hi Jason,

I really appreciate your contributions to Bridge Troll.  I just merged #628.  Would you (or anyone) have time to pair on reviewing / merging PRs this weekend?   

I had an unexpected personal crisis, which is thankfully over now.  Unfortunately, I'm the only active committer; however, I'm taking a bit of time off over the next couple of months and I'd like to work with folks to develop good practices for reviewing merging. 

Thanks!
Sarah


--

Sarah Allen

unread,
Mar 24, 2019, 11:46:33 AM3/24/19
to Jason Hsu, Bridge Troll
FYI -- did some work on PRs yesterday.  Got down to 10 open PRs.  If anyone wants to review and comment on open PRs that would be very helpful.  I also just added "Help Wanted" tag to new issue about generating an ERD -- I think this is a really neat idea, but may be a bug in the rails-erd gem, which might be fun for someone to look into.  

Thanks everyone for your patience while we re-boot the community of contributors here!

Sarah

Jason Hsu

unread,
Mar 24, 2019, 8:26:24 PM3/24/19
to Bridge Troll
OK, I understand.  The reboot of the team gives me motivation to work on this app and to review PRs.

Sameer Siruguri

unread,
Apr 5, 2019, 1:20:39 AM4/5/19
to Jason Hsu, Bridge Troll
I just wanted to add that I submitted a PR for a gem vulnerability fix, and also threw in a screenshot in a PR that might help close that PR.

I will try to keep helping out with closing PRs. Maybe while classes are going at this week's SF Railsbridge! :)


Sarah Allen

unread,
Apr 5, 2019, 5:25:12 AM4/5/19
to Sameer Siruguri, Jason Hsu, Bridge Troll
merged those two and pushed to staging / production.

Now down to 8 PRs... though there are a couple of other gem upgrades that should prolly take precedence.  Note that when I worked on some upgrades with Rachel Ober a little while ago, I ended up doing it in stages and there's a few testing gems that seemed to need code changes in order to be upgraded (see issue#615)

Thank you so much!   

Sarah




Reply all
Reply to author
Forward
0 new messages