PIvotal vis-a-vis Github Issues - owning/commenting on a feature

14 views
Skip to first unread message

Sameer Siruguri

unread,
Apr 23, 2015, 12:21:40 AM4/23/15
to bridge...@googlegroups.com
Hi -

I'm interested in working on a feature that Lillie created on Pivotal - events in draft state.

https://www.pivotaltracker.com/story/show/83605984

I tried following it on Pivotal but couldn't figure where to click on their UX... or what I could do to ask for ownership. Also, should there be a copy on Github for discussion or do we discuss on Pivotal?

Specifically I was curious if folks would like to do a design review before any coding gets started, or would like to wait for a PR and do a code review at that point? For example, I see that events currently have a published Boolean... so if we were to add another "state" variable, one could propose doing that with just another column, or convert published to an enum... I would rather have that discussion before committing to a strategy in code.

Thanks!
Sameer.


Lillie Chilen

unread,
Apr 23, 2015, 3:15:49 PM4/23/15
to Sameer Siruguri, bridge...@googlegroups.com
Communication / Housekeeping Things
Cool — as for Pivotal Tracker stuff, I've sent you an invite for the project so that you can start the story. If you have a Tracker account under a different email address than siru...@gmail.com, let me know and I can send another invite.

I'm not sure where the perfect place for discussion is. How about here on this mailing list? It's easier for people to discuss here than on Tracker since not everyone has Tracker accounts, and I don't really want to have a duplicate issue for it on GitHub.

Code Things
I'm not sure if it should be another column or an enum. It certainly seems like adding a third or fourth state points to an enum rather than a proliferation of state columns, but I also can't think of further states ATM.

--
You received this message because you are subscribed to the Google Groups "Bridge Troll" group.
To unsubscribe from this group and stop receiving emails from it, send an email to bridge-troll...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.



--
Lillie Chilen
@lilliealbert
('li-lee shuh-'leen)

Sameer Siruguri

unread,
Apr 23, 2015, 3:29:17 PM4/23/15
to Lillie Chilen, bridge...@googlegroups.com
I got the Pivotal invite, thanks.

Discussion on mail is fine by me... I usu make a ref/summary back into the SCMS when the discussion is done.

I'm not particular to either approach ... 3-4 state columns seem reasonable. Perhaps even up to 6-7 I would find tolerable.

I recently used enums in a case where there was a five step wizard, but that's because it was very specifically a wizard UX with the user possibly bailing in the middle without warning. But this isn't quite the same.

I'll give it a few days for more inputs and then move fwd with Lillie's suggestion.

Sameer.

Sarah Allen

unread,
Apr 23, 2015, 8:11:18 PM4/23/15
to Sameer Siruguri, Lillie Chilen, bridge...@googlegroups.com
As far as future states, I've sometimes wondered if it might be helpful to (in the future) have a "review" state where new organizers could submit a draft for review, which then would get picked up by a volunteer mentor (who would also potentially mentor them throughout the process).

Just an idea, but i think there's room for additional states in the future :)

Sarah

Sameer Siruguri

unread,
Apr 23, 2015, 8:39:24 PM4/23/15
to Sarah Allen, Lillie Chilen, bridge...@googlegroups.com
The draft-to-published behavior already exists, right? I didn't dig into the code but I think it emails someone from a list of users with a given role ('publisher?'), once an event is created. Then the event has to be set as published.

Are you suggesting more roles than the ones already there?

 

Sarah Allen

unread,
Apr 23, 2015, 8:58:25 PM4/23/15
to Sameer Siruguri, Lillie Chilen, bridge...@googlegroups.com
For this issue:  https://www.pivotaltracker.com/n/projects/608983/stories/83605984
The idea of a personal draft is being introduced, so there will be three states
1) personal draft
2) submit for publication
3) publish

I haven't created an event in a long time, but I don't think the organizer chooses between 2 & 3.  I was thinking that people might want to someday ask for review with the intent to leave it as a draft (rather than please-publish-if-you-approve), likewise, an organizer who has permission to publish could potentially request a review -- I haven't really thought through this, so definitely in favor of implementing the simple addition of the third state now!

Sarah 



Sameer Siruguri

unread,
Apr 29, 2015, 8:34:50 PM4/29/15
to Sarah Allen, Lillie Chilen, bridge...@googlegroups.com
Okay, I'll go with this implementation proposal - I'll formally assign the task to myself.
Reply all
Reply to author
Forward
0 new messages