Questions about Brick Extensions

[Steve Appling]

I'm attempting to declare some Python-based Extensions as described here.

Here's a snippet of what I am trying:

classes = {
    BRICK.Equipment: {
        CAR["Plate_Heat_Exchanger"]: {
            "parents": [BRICK.Heat_Exchanger],
            "tags": [TAG.Plate, TAG.Heat, TAG.Exchanger, TAG.Equipment],
            RDFS.label : rdflib.Literal("Plate Heat Exchanger"),
            SKOS.definition : rdflib.Literal("A heat exchanger that transfers heat between two separate fluids through thin metal plates.")
        },
    },
}

This runs without errors, but I have a few questions:

Tags - this adds all the tags to the resulting TTL file, but it also duplicates the Tags that are already defined in brick.  Is this problematic in any way?  It doesn't add the rdfs:label to the tags like what is done in brick.ttl?  Should it?

Other properties - I attempted to follow the logic in define_classes for the other_properties, but this isn't doing what I expected.  I was attempting to define a label and definition for this new Equipment, but those other properties seem to have no effect.  How should I add additional properties?

[Steve Appling]

I found the problem with adding other properties.  I created a pull request with the fix.