Slow rendering issue with renderBox

[Mitsutoshi Aoe]

Hi all,

I'm now trying out brick in my project[1] and found it a bit sluggish when I have a large number of items in a vBox.

Does anyone have an idea to speed it up?

Here are the instructions to reproduce the issue:

git clone https://github.com/maoe/viewprof.git

cd viewprof

stack build

wget https://gist.githubusercontent.com/maoe/b4f17cc8b7a3b4c90ea4ab2625e5e8b4/raw/9f2958d10487c18768cf63e556c268cff9a59a49/viewprof.prof

stack exec viewprof -- viewprof.prof

then type j to move the cursor.

At a quick glance, renderBox seems to traverse the argument list and forces its items regardless of their visibility, meaning that it renders all the AggregateCostCentres every time it processes an event. Should I somehow make renderBox lazier or should I consider using caching?

[1]: https://github.com/maoe/viewprof

[2]: https://gist.github.com/maoe/b4f17cc8b7a3b4c90ea4ab2625e5e8b4

Thanks,

Mitsutoshi

[Mitsutoshi Aoe]

I worked around this issue with a performance improvement[1] in brick and caching[2] in viewprof. HEAD is now fast enough to display the report in question.

Regards,

Mitsutoshi

[1]: https://github.com/jtdaugherty/brick/pull/107

[2]: https://github.com/maoe/viewprof/commit/35210dfded0c6b0240fd11abf28846665c5afcd9

2016年12月29日木曜日 0時51分25秒 UTC+9 Mitsutoshi Aoe:

[drcy...@gmail.com]

Hi,

Judging by the pull request you sent, it looks like you've been able to get past the performance issue you encountered. Thanks for the patch! And let me know if anything else arises.