Javascript SDK Tidy-up ?

[Dobes Vandermeer]

Hi Guys,

I checked out brassmonkeyjs from github, and I found it looks a bit messy in there.

I noticed the brassmonkey.js is about half minified and half not.    There seems to be a minified and non-minified version of the "getInternetExplorerVersion" function in that file, and there might be more duplication too.

There seems to be a whole bunch of folders named ".settings" and ".metadata" and ".mylyn" and "*.launch" that are not very interesting or useful to me right now, and the src folder is completely useless.  A bit of a clean-up might be warranted - first impressions count!

Cheers,

Dobes

[Francois Laberge]

Hey Dobes,

Definitely appreciate the feedback on first impressions. Totally understand that some of it looks like noise. The .settings/.metadata are both related to our Flex project we commit so other people can see how we built our wrapper on top of the Flash SDK. 

I'll make a note to document the folder/file layout more so that everything is explained. Would love your feedback on the changes when we push them.

Francois

--
 
---
You received this message because you are subscribed to the Google Groups "Brass Monkey SDK" group.
To unsubscribe from this group and stop receiving emails from it, send an email to brassmonkey-s...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
 
 

--

Francois Laberge

CTO

Brass Monkey Inc.

http://playbrassmonkey.com/ 

San Francisco | Boston

[Francois Laberge]

Addressing the half minified part. I'll see what I can do about that. It's unfortunate that our Websockets release got delayed as we'd spent a lot of time cleaning up the code and breaking it into modules and such as well as using a documentation generator on the highly commented code.

What kind of controller were you thinking of building. I can definitely help give you pointers. 

Francois

[Dobes Vandermeer]

Hi Francois,

At first I'm just going to make a simple four directions and attack controller.  Maybe later I'll try something more fancy.  I think there's a few examples of this included with the SDK already, I'll start with those.

[Francois Laberge]

Cool sounds good. We actually just added a built in Dpad element to our controller app. We need to update our HTML5 SDK to expose it. Shouldn't be much work. So don't spend too much time getting your own dpad tuned correctly using buttons or anything.

Keep me posted,

Francois

Sent from my iPhone

[Dobes Vandermeer]

No, you keep ME posted!

:-P

[Francois Laberge]

:)

Sent from my iPhone