Database Subnet Groups

[Franc Carter]

Hi,

I noticed that Database Subnet Groups aren't on boto at the moment, so I had a go at adding support for them.

I'd be interested in getting this in to the mainline support - however I don't do software or python much for my day job, and I'm not familiar with committing to boto. So I'm wondering is someone can have a look over:-

   https://github.com/franc-carter/boto

and let me know what I may have missed in function/style/anything to for this to be considered for the mainline

thanks

--
Franc

[Andres Riancho]

Franc,

I'm stuck with this missing feature too. Have you tried to send a pull request to the main boto repository? Maybe that's a better way to get their attention? If you send them a pull-request, please send us all the link so we can review.

Also, please send me the link to your repository changeset(s) so I can review them on my own and try to use them in my environment while they pull it into boto,

 

thanks

--
Franc

[Franc Carter]

On Fri, May 17, 2013 at 7:49 AM, Andres Riancho <andres....@gmail.com> wrote:

Franc,

On Sunday, March 24, 2013 12:34:14 AM UTC-3, Franc Carter wrote:

Hi,

I noticed that Database Subnet Groups aren't on boto at the moment, so I had a go at adding support for them.

I've been quite distracted recently, so just completely forgot - thanks for the prompt this is something I care about.

I'll get back to this on the weekend, do the pull request and send you the link

cheers
 

I'd be interested in getting this in to the mainline support - however I don't do software or python much for my day job, and I'm not familiar with committing to boto. So I'm wondering is someone can have a look over:-

   https://github.com/franc-carter/boto

and let me know what I may have missed in function/style/anything to for this to be considered for the mainline

I'm stuck with this missing feature too. Have you tried to send a pull request to the main boto repository? Maybe that's a better way to get their attention? If you send them a pull-request, please send us all the link so we can review.

Also, please send me the link to your repository changeset(s) so I can review them on my own and try to use them in my environment while they pull it into boto,

 

thanks

--
Franc

--
You received this message because you are subscribed to the Google Groups "boto-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to boto-users+...@googlegroups.com.
To post to this group, send email to boto-...@googlegroups.com.
Visit this group at http://groups.google.com/group/boto-users?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
 
 

--
Franc

[Franc Carter]

On Fri, May 17, 2013 at 7:49 AM, Andres Riancho <andres....@gmail.com> wrote:

Franc,

On Sunday, March 24, 2013 12:34:14 AM UTC-3, Franc Carter wrote:

Hi,

I noticed that Database Subnet Groups aren't on boto at the moment, so I had a go at adding support for them.

I'd be interested in getting this in to the mainline support - however I don't do software or python much for my day job, and I'm not familiar with committing to boto. So I'm wondering is someone can have a look over:-

   https://github.com/franc-carter/boto

and let me know what I may have missed in function/style/anything to for this to be considered for the mainline

I'm stuck with this missing feature too. Have you tried to send a pull request to the main boto repository? Maybe that's a better way to get their attention? If you send them a pull-request, please send us all the link so we can review.

I've been reviewing the contributing guidelines (they are actually clearly in the distribution - I should have looked earlier). The main thing I see that I am missing is docs. I'll add these before doing the pull-request

 

Also, please send me the link to your repository changeset(s) so I can review them on my own and try to use them in my environment while they pull it into boto

In the meantime, here is a link to my branch that has the changes in it. I just merged the latest changes in from the main develop repo, so hopefully it won't be too much of problem for you to use

 https://github.com/franc-carter/boto/commit/b113dc5985350973a04db6404298faa7d7b3e6b1

 

cheers

 

thanks

--
Franc

--
You received this message because you are subscribed to the Google Groups "boto-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to boto-users+...@googlegroups.com.
To post to this group, send email to boto-...@googlegroups.com.
Visit this group at http://groups.google.com/group/boto-users?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
 
 

--
Franc

[Franc Carter]

Pull request at

https://github.com/boto/boto/pull/1500

cheers

On Fri, May 17, 2013 at 7:49 AM, Andres Riancho <andres....@gmail.com> wrote:

--

You received this message because you are subscribed to the Google Groups "boto-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to boto-users+...@googlegroups.com.
To post to this group, send email to boto-...@googlegroups.com.
Visit this group at http://groups.google.com/group/boto-users?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
 
 

--
Franc

[Andres Riancho]

Doh! I failed to read this final email and created a pull request with your code:

https://github.com/boto/boto/pull/1507

I closed my pull-request since it was a little bit worse than yours :) Now... who do we need to nag to get this merged into develop? :D

Regards,