I'd like to merge the following bugfixes:
https://github.com/boostorg/geometry/pull/1028
https://github.com/boostorg/geometry/pull/1036
https://github.com/boostorg/geometry/pull/1038
https://github.com/boostorg/geometry/pull/1042
https://github.com/boostorg/geometry/pull/1043
Adam
> On Aug 2, 2022, at 7:37 AM, Nathaniel Groendyk via Boost <bo...@lists.boost.org> wrote:
>
> Hi all,
>
> I'd like to merge bugfix: https://github.com/boostorg/asio/pull/394
> which fixes: https://github.com/chriskohlhoff/asio/issues/1098
>
> However, I am not sure if this is the proper workflow for submitting
> proposed fixes (I am new to contributing to boost), but thought I would
> post it here just to bring it to attention before master is closed.
> If I am in err, could someone point me to any docs about the proper
> workflow for submitting a bugfix :)
>
> Thanks
> Nate
>
>
> On Tue, Aug 2, 2022 at 10:24 AM Adam Wulkiewicz via Boost <
> bo...@lists.boost.org> wrote:
>
>> W dniu 14.07.2022 o 13:35, Glen Fernandes via Boost pisze:
>>> Now open for bug fixes and documentation changes. Other changes by
>>> release manager permission.
>>>
>>> The next deadline: On August 3rd, master closes for all changes.
>>
>> I'd like to merge the following bugfixes:
>>
>> https://github.com/boostorg/geometry/pull/1028
>> https://github.com/boostorg/geometry/pull/1036
>> https://github.com/boostorg/geometry/pull/1038
>> https://github.com/boostorg/geometry/pull/1042
>> https://github.com/boostorg/geometry/pull/1043
If you’re happy with the test results, go ahead.
— Marshall
You’ve made a good start.
You submit a PR against the develop branch of some library (ASIO, in this case). Ok, you’ve done that.
The owner of the library reviews/approves/rejects/asks for revisions of the PR. That doesn’t appear to have happened.
The PR gets merged to the ‘develop’ branch. This hasn’t happened, either.
The CI tests run. The test bots run. The results are inspected.
When the tests look good, the library owner merges the change is ‘develop’ into ‘master’, where it shows up in a release.
— Marshall
This is how it works for most libraries, but not for Boost.ASIO in
particular. ASIO is being developed at
https://github.com/chriskohlhoff/asio, so that's where you originally
submit the PR or otherwise try to integrate your changes. Then Chris
will generate Boost.ASIO from that project, and at that point the fix
will propagate to Boost.