Versions 3.2.3--patches to bugs

0 views
Skip to first unread message

The Editor

unread,
Oct 9, 2009, 4:01:17 PM10/9/09
to bolt...@googlegroups.com
Sorry for having to get 3.2.1 up to speed so fast, but I wanted to get
the security fix out right away. Here's quick patches to the latest
release.

First as for the & symbol in the links. This is a result of the recent
changes in how BoltWire escapes things. To reverse this, and fix the
bug, comment out this line, engine.php 1801

// BOLTreplace('&', '&');

It has the interesting effect of doing what Hans has been arguing for
with  , but we lose xhtml compliance in some situations, and we
do get some of our old quirky behavior back. But Hans made good
points. I'm hoping we can find other ways to solve those problems...

As for the messages not showing--it seems to only happen when you have
==[messages]== in the skin. Even an extra space should fix it.
==[messages] == is a workaround. But the fix is to go to BOLTdomarkup
(engine.php ~730) and comment out this line.

// if ($content == '[messages]' && $BOLTmsgOut == '') return;

By the way, the way we fixed the messages to get the cool new
functionalities was something I tried to do once before but couldn't
get the wiring right. This time we seem to have it! In particular, we
should be able to output regular messages in markup functions now with
no problem. Just did some testing. Very exciting!!!

Try this function in config.php just for kicks. I'll be tweaking it
more and reviewing all our existing functions when I get time.

function BOLTFmsg($args, $zone='') {
global $BOLTsession;
$BOLTsession['MSG']['msg_form']['hi'] = 'Hello!';
}


Cheers,
Dan

P.S. I also put out 3.2.3 if you care to download the new version
rather than patch the code. We really need to figure out for sure what
to do about our numbering system... :) 3.18 (3.2) didn't stay stable
for very long, did it?

UKDutyPaid

unread,
Oct 10, 2009, 4:48:20 AM10/10/09
to BoltWire
Lol, 1093 in engine.php is $out = boltloadpage($link) . "\n\n";

I have changed to $out = boltloadpage($link); on my site ;-)

Hans

unread,
Oct 10, 2009, 5:48:56 AM10/10/09
to bolt...@googlegroups.com
2009/10/10 UKDutyPaid <ukdut...@gmail.com>:

>
> Lol, 1093 in engine.php is $out = boltloadpage($link) . "\n\n";
>
> I have changed to $out = boltloadpage($link); on my site ;-)

I think adding a single newline may be better:

$out = boltloadpage($link) . "\n";

then follow the last paragraph on a page with an extra line, which
will assure it is enclosed by <p> </p> tags, same as for all
paragraphs.

Adding two newlines at the end of a zone is confusing and messes up
some zone spacing.
For instance there was an extra space below the top menu, before
logging on, but not after logging on. Probably due to some newline
space due to using [if] conditionals.

Hans

unread,
Oct 10, 2009, 6:48:46 AM10/10/09
to bolt...@googlegroups.com
Dan, I like to add that I am very glad that you removed the "escaping" of '&',
and standard html special character code can be used again, and is
saved as code!

Hans

unread,
Oct 10, 2009, 7:09:23 AM10/10/09
to bolt...@googlegroups.com
> Dan, I like to add that I am very glad that you removed the "escaping" of '&',
> and standard html special character code can be used again, and is
> saved as code!

Actually, I spoke too soon!
html character codes are saved as codes originally,
but when I open the page again for editing,
the codes don't show, but the special characters are displayed in the edit box.
When I save again, those special characters are saved.
So when the page text to display in the text box for editing,
character codes are decoded. I think they should be shown as is, not decoded.

The Editor

unread,
Oct 11, 2009, 6:27:35 AM10/11/09
to bolt...@googlegroups.com

Yes, we are working on it. I think it is fixed in 3.2.4 now.

Cheers,
Dan

Reply all
Reply to author
Forward
0 new messages