Spot for test utility classes?

[Fr Jeremy Krieg (Home)]

Hi team,

I pray that you're all well.

I'm working on an enhancement to bnd to put file locking around the reading/writing of the launcher properties file. For proper testing, I need to be able to have another process to lock the file, so I've written a class that fires up a remote JVM and allows you to send commands to the JVM to lock/unlock files.

I'd like to use the class in tests in more than one project (in aQute.lib and in biz.aQute.launcher), so it would be nice if I could put it somewhere. However, given that the class is really only useful for testing, I don't want to put it somewhere where it will unnecessarily clutter bnd's application code.

Where is the best place in the bnd workspace to put a test utility class like this?

Blessings,

Fr Jeremy

[Peter Kriens]

If you can make it a small uncoupled utility I suggest to put it in aQute.lib in a separate package.

Kind regards,

Peter Kriens

--
You received this message because you are subscribed to the Google Groups "bndtools-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to bndtools-dev...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/bndtools-dev/CAO6F8YwbZVpsJOfcoKbOdTko3FcX6OkRC2dBEPA%3DWWdobQFzEA%40mail.gmail.com.

[BJ Hargrave]

biz.aQute.bnd.tests already holds some test utility classes. I would use that since it already is for this purpose and has junit on the -buildpath. In general we do not want to put junit on a project's -buildpath.

To view this discussion on the web visit https://groups.google.com/d/msgid/bndtools-dev/9AC58E1D-530A-4925-83B1-C62CECC4F9D5%40aqute.biz.

--

BJ

[Fr Jeremy Krieg (Home)]

Thanks to you both for your suggestions.

I ended up creating aQute.lib.test and putting it there. Reasoning:

* I was using it in aQute.lib.io.IOTest, and so putting it in biz.aQute.bnd.tests may have inverted the dependency tree;

* biz.aQute.bnd.tests seems to have all of its code in the test directory, which isn't visible to other projects. I guess I could have put it in the src directory under this project, but it would have been lonely. :)

Blessings,

Fr Jeremy

To view this discussion on the web visit https://groups.google.com/d/msgid/bndtools-dev/CABr4vaz0GOs%3DVRh6_u-d-AxYno6qWg7Gega%3DGnFP60HB6_p86g%40mail.gmail.com.