Block (factory) Library: base block gone after manually edit generated JSON

[Charles Lee]

Hi guys,

I found a bug in block factory library demo when trying to customise it to suit my project.

Reproduce step: (See screenshot for more details)

1. Open the demo and change the block type in base block, e.g. I changed it to "test";
2. Change the Block Definition format to "Manual JSON..." and make a change, e.g. I changed colour
3. Switch the Block Definition format back to "JSON", the changes stays in preview workspace, but the base block in main workspace is gone.  
   
   

Please help. Any idea is appreciated. 

Charles.

[Charles Lee]

Found the problem. The following function has not been defined. 

Blockly.hueToRgb(hue)

To fix it, replace line 718 - 720 with the following code.

var colourHex = Blockly.utils.colour.hsvToHex(hue, Blockly.HSV_SATURATION, 255 * Blockly.HSV_VALUE);

colourBlock.append(BlockDefinitionExtractor.newDomElement_('mutation', {

    colour: colourHex

}));

I will report this in GitHub later today.

[Christopher Allen]

On Wednesday, 25 May 2022 at 07:54:42 UTC+1 tuba...@gmail.com wrote:

Found the problem. The following function has not been defined. 

Blockly.hueToRgb(hue)

To fix it, replace line 718 - 720 with the following code.

var colourHex = Blockly.utils.colour.hsvToHex(hue, Blockly.HSV_SATURATION, 255 * Blockly.HSV_VALUE);

colourBlock.append(BlockDefinitionExtractor.newDomElement_('mutation', {

    colour: colourHex

}));

I will report this in GitHub later today.

Great!  I see your report of issue #6175; thanks for that.

Christopher