field-grid-dropdown plugin menu overflow

[Thanuditha Ruchiranga]

Hi all,

While using the field-grid-dropdown plugin I noticed if you place a block close to the edge of the workspace and open the dropdown menu, it overfows out of the workspace. 

Going though the code, I noticed the showEditor_ function does not have the 

Blockly.DropDownDiv.showPositionedByField(this, this.dropdownDispose_.bind(this));

call which other plugins like the field-slider has and calling it there did indeed solve the problem.

I opened a PR with the change and would like to know if you have any comments on this.

Thanks!

Ruchi

[Beka Westberg]

Hi Ruchi,

Thank you for taking the time to look into this and post a PR! From taking a quick look it seems like a great submission =)

Usually it takes the core team members a few days to respond to PRs (they're very busy working on internal stuff) so it'll probably be next week before you get comments on it :/  However don't let that discourage you! I'm sure they definitely want to get this fix in, reviewing code just takes time hehe.

On a different note, it's always really cool to hear about people using plugins in the wild :D May I ask what you're using it for?

Thank you again for your submission :D Oh, and if you have any questions about the review process (or anything else) feel free to ask!

Best wishes,

--Beka

--
You received this message because you are subscribed to the Google Groups "Blockly" group.
To unsubscribe from this group and stop receiving emails from it, send an email to blockly+u...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/blockly/19df24d1-9aad-47d4-b4b4-478eefcdbc62n%40googlegroups.com.

[Ruchiranga Wickramasinghe]

Hi Beka,

Thanks a lot for the response! :)

I am working on a project at Logitech to introduce visual programming to a scripting tool we already have. Wanted to have a dropdown list with a big list of items and saw this grid dropdown plugin is way more handier than the plain one ;)

Now that you mentioned it, I'd actually like to know more about the review process :D What happens after someone from the core team takes a look at it?

Cheers,

Ruchi

[Maribeth Bottorff]

Hi, thanks for the PR! There's some info about the general code review process here: https://developers.google.com/blockly/guides/modify/contribute/write_a_good_pr (and there's some related pages that might also be helpful). Code review often has a couple of rounds of back and forth depending on the size and nature of the change. Once it's approved for submission, someone on the team will merge it to the main branch (master on blockly-samples, develop on blockly). blockly-samples releases weekly on Thursdays so the change will be live pretty quick once it's merged in. I've assigned your PR to the author of the plugin, so you should hear back on the code review soon. Thanks again for contributing!

[Ruchiranga Wickramasinghe]

Hi Maribeth,

Thanks for sharing the details. Nice to know releases happen weekly! :)

Ruchi

[Beka Westberg]

Hi Ruchi,

> I am working on a project at Logitech to introduce visual programming to a scripting tool we already have. Wanted to have a dropdown list with a big list of items and saw this grid dropdown plugin is way more handier than the plain one ;)

That is so cool! Normally we hear about Blockly being used for educational purposes, so it's always interesting to find out about the other ways people are using it. I think scripting languages are super cool in general, and blocks-based ones even more so. I love projects that help non-programmers communicate with their computers =)

If you have time, you might be interested in coming to the Blockly Summit in April. I'm sure other people would be interested to hear about how you use Blockly too :D

On a different note, I'm glad that the grid dropdown plugin was useful to you! Blocks based programming languages do seem to struggle with displaying a lot of information at once, so it's great to hear that the grid dropdown field is helping to solve that problem.

Thanks again for sharing what you're working on! I find this stuff endlessly interesting hehe.

Best wishes,

Beka

On Friday, February 19, 2021 at 1:37:47 PM UTC-8 truch...@gmail.com wrote:

[Ruchiranga Wickramasinghe]

Hi Beka,

Didn't know there is a Blockly Summit and indeed it sounds interesting. Thanks for sharing the info!

By the way, I'm just curious, is there any discussion group on deciding which examples/plugins go into the blockly-samples repository? The reason that I am asking this is that for the project I work on, I might create a dropdown that has a keyboard layout and if this is something that would possibly be useful to others as well, I would be happy to create a plugin and submit a PR.

I would also be interested in knowing if there is a list of plugins that the blockly team wishes to have implemented in the future so that if any of those ideas align with something that I could probably use in my work as well, I could contribute in developing them.

Thanks

Ruchi

[Beka Westberg]

Hi Ruchi,

I saw your change just got merged today, congratulations!

> By the way, I'm just curious, is there any discussion group on deciding which examples/plugins go into the blockly-samples repository?

If you want to suggest a plugin (including one you want to build) you can create a feature request in the blockly-samples repo for it =) The core team lists some good first party plugin (ie blockly-samples plugin) criteria here, and they get final say on what gets into blockly-samples and what doesn't. There are more details on plugin suggestions (and the rest of the process) here.

With regard to discussion groups, as far as I know this is the only one. But who knows, there could be secret ones I don't know about haha.

>  The reason that I am asking this is that for the project I work on, I might create a dropdown that has a keyboard layout and if this is something that would possibly be useful to others as well, I would be happy to create a plugin and submit a PR.

That sounds like a really cool field! And it sounds like it would be generally useful for applications that allow people to create keyboard shortcuts :D I think you should definitely suggest adding this as a plugin! Especially if you're willing to build it. I'm not on the core team, so I don't have any deciding power, but if I did I would definitely accept it.

> I would also be interested in knowing if there is a list of plugins that the blockly team wishes to have implemented in the future so that if any of those ideas align with something that I could probably use in my work as well, I could contribute in developing them.

All plugin suggestions are tracked using inside blockly-samples issue tracker using the labels help wanted and plugin. As you can see, many of those issues also have status labels, which are documented here. I'm sure there are other things the core team would be interested in as well, but these are the ones that have been documented =)

I hope that helps! If you have any more questions about contributing, as always feel free to ask!

Best,

Beka

To view this discussion on the web visit https://groups.google.com/d/msgid/blockly/cf557877-07e9-4728-9027-6b9288b5e42fn%40googlegroups.com.

[Abby Schmiedt]

Hello!

I am on the core team and can confirm that this field sounds like a great addition to blockly samples. The next step like Beka said would be to create a feature request on blockly samples and mention that you are interested in working on it. We are also interested in getting feedback from external developers on our process for writing a plugin, so at any point if something is confusing or you feel like it could be improved let us know!

Cheers,

Abby

[Ruchiranga Wickramasinghe]

Hi Beka and Abby,

Sorry for the late response.

Thank you both for all the information you shared! 

I opened a feature request issue describing the plugin and the API I think it should provide.

Waiting to hear feedback from the community and the team! :)

Cheers,

Ruchi