Blocks and Hats

[Jorge Bonafé]

My application has a "Main" type block and several "Event" type blocks. I understand how to add hats to all blocks, but I can't figure out how to add hats only to the event blocks, and not the Main block. Is that possible? I'm trying to do that on all versions of blockly, web, ios and android.

Thanks in advance

[Neil Fraser]

Currently it is an all-or-nothing option for blocks that have no previous connections or output connections.  However, you are definitely not the first person to request selective hat availability.

On 21 August 2017 at 15:10, Jorge Bonafé <jorge...@gmail.com> wrote:

My application has a "Main" type block and several "Event" type blocks. I understand how to add hats to all blocks, but I can't figure out how to add hats only to the event blocks, and not the Main block. Is that possible? I'm trying to do that on all versions of blockly, web, ios and android.

Thanks in advance

--
You received this message because you are subscribed to the Google Groups "Blockly" group.
To unsubscribe from this group and stop receiving emails from it, send an email to blockly+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

--

Neil Fraser
https://neil.fraser.name

[Jorge Bonafé]

Allright, in the meantime I forked it and made the changes on IOS myself. I'll do something on the other versions later.

I added a json boolean property "startHat: true" that sets it to show the hat on the desired block.

If anyone is interested, the code is here:

https://github.com/jorgebonafe/blockly-ios.git

[Jorge Bonafé]

... And here's the android version:

https://github.com/jorgebonafe/blockly-android/commit/1e618c7bbf61d2bed3284794ec35a701fe6756d4

[Victor Ng]

Thanks for pointing this out Jorge. We had a team discussion and we agreed that this is useful!

As of PR #449 on iOS, it now accepts individual hats per block. You can specify it on the block JSON definition as follows:

eg.

{

  "name": "some_block",

  "style": {

    "hat": "cap"

  }

}

Possible values for "hat" are:

"cap"

"none"

We're working to get it implemented on the other platforms as well. Here are the open issues for those:

Web: https://github.com/google/blockly/issues/1325

Android: https://github.com/google/blockly-android/issues/659

[Jorge Bonafé]

Allright, I'll update my code. Thank you.

[Andrew n marshall]

Jorge,

When you do, would you mind making pull request, based on the develop branch?  It would be much appreciated.

--
Andrew

On Wed, Sep 20, 2017 at 1:51 PM, Jorge Bonafé <jorge...@gmail.com> wrote:

Allright, I'll update my code. Thank you.

--

[Jorge Bonafé]

Forgive my lack of understanding of git, can you clarify what that means?

[Andrew n marshall]

A pull request is a GitHub process for developers to contribute code to a repository they do not own, complete with a code review pass.

Basically, after checking out a copy of Google's develop branch, make the changes there upload it back to github under a new branch name. Then, when you go to the GitHub page for your fork or our original, you'll see a button to make a pull request based on your new branch.

These two pages seem to have more details:

https://akrabat.com/the-beginners-guide-to-contributing-to-a-github-project/

http://kbroman.org/github_tutorial/pages/fork.html

If this seems complicated, your code looks small enough I can copy the work manually, if need be.

Thanks.

--
Andrew

On Wed, Sep 20, 2017 at 1:57 PM, Jorge Bonafé <jorge...@gmail.com> wrote:

Forgive my lack of understanding of git, can you clarify what that means?

--

[Jorge Bonafé]

I see. But I was under the impression the changes were already made on the official code. Or do you mean you'd like me change my Android fork to reflect the changes on the IOS version?

If that's the case, the thing is, I changed a bunch of other unrelated stuff on my Android fork. Wouldn't that be a problem?

[Andrew n marshall]

You've made changes on your fork. Note the jorgebonafe in the following URL:

https://github.com/jorgebonafe/blockly-android/commit/1e618c7bbf61d2bed3284794ec35a701fe6756d4

--
Andrew

On Wed, Sep 20, 2017 at 3:15 PM, Jorge Bonafé <jorge...@gmail.com> wrote:

I see. But I was under the impression the changes were already made on the official code. Or do you mean you'd like me change my Android fork to reflect the changes on the IOS version?

If that's the case, the thing is, I changed a bunch of other unrelated stuff on my Android fork. Wouldn't that be a problem?

--

[Jorge Bonafé]

What I mean is, I also made changes that have nothing to do with the hat code, so I'm wondering if that's not a problem when I do the pull request with all those other unrelated changes.

In any case, I did the pull request. Let me know if I did that correctly.

[Andrew n marshall]

Because it has so many other changes, I'm going to decline this PR. This is why PRs should generally start with a clean copy of the develop branch.

But this is not a big problem. I'm happy to make the PR myself. It will just take more time to get it in. It may cause minor conflicts if you pull from our repo in the future, but they should be trivial to resolve.

--
Andrew

On Wed, Sep 20, 2017 at 4:34 PM, Jorge Bonafé <jorge...@gmail.com> wrote:

What I mean is, I also made changes that have nothing to do with the hat code, so I'm wondering if that's not a problem when I do the pull request with all those other unrelated changes.

In any case, I did the pull request. Let me know if I did that correctly.

--