[bliki] Issue 37 in gwtwiki: first letter of link was not encoded.

2 views
Skip to first unread message

gwt...@googlecode.com

unread,
Apr 27, 2010, 10:49:47 AM4/27/10
to bl...@googlegroups.com
Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 37 by masayan68: first letter of link was not encoded.
http://code.google.com/p/gwtwiki/issues/detail?id=37

What steps will reproduce the problem?
1. set up the WikiModel, passing in "/wikiDocument.do?title=${title}" as
the base link uri
2. pass in an internal link: [[Japanese title]]
3. receive back the html: <a href="/wikiDocument.do?title=Japanese title
not encoded first letter">Japanese title</a>


What is the expected output? What do you see instead?
input: [[京都市]]
expected output: <a
href="/wikiDocument.do?title=%E4%BA%AC%E9%83%BD%E5%B8%82">
instead output: <a href="/wikiDocument.do?title=京%E9%83%BD%E5%B8%82">

What version of the product are you using? On what operating system?

product:bliki-core-3.0.13
on:Windows 7, Windows XP

Please provide any additional information below.

Encorder.encodeTitleToUrl/encodeTitleDotUrl.
In these functions, please encode first character too.

thanks.


--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups "Bliki - Java/Eclipse Wikipedia API" group.
To post to this group, send email to bl...@googlegroups.com
To unsubscribe from this group, send email to bliki-un...@googlegroups.com
For more options, visit this group at http://groups.google.com/group/bliki?hl=en
or visit the projects homepage at http://matheclipse.org/en/Eclipse_Wikipedia_Editor

gwt...@googlecode.com

unread,
Apr 28, 2010, 3:17:20 PM4/28/10
to bl...@googlegroups.com
Updates:
Status: Accepted
Owner: axelclk

Comment #1 on issue 37 by axelclk: first letter of link was not encoded.
http://code.google.com/p/gwtwiki/issues/detail?id=37

(No comment was entered for this change.)

gwt...@googlecode.com

unread,
Apr 28, 2010, 3:21:26 PM4/28/10
to bl...@googlegroups.com

Comment #2 on issue 37 by axelclk: first letter of link was not encoded.
http://code.google.com/p/gwtwiki/issues/detail?id=37

Try these changes in the info.bliki.wiki.filter.Encoder
http://code.google.com/p/gwtwiki/source/detail?r=1108

or override the encodeTitleToUrl() and encodeTitleDotUrl() methods in your
IWikiModel
implementtion like this, if you don't need the conversion to uppercase
character for
the first character of the title:

{{{
public String encodeTitleToUrl(String wikiTitle, boolean
firstCharacterAsUpperCase) {
return Encoder.encodeTitleToUrl(wikiTitle, false);
}

public String encodeTitleDotUrl(String wikiTitle, boolean
firstCharacterAsUpperCase) {
return Encoder.encodeTitleDotUrl(wikiTitle, false);

gwt...@googlecode.com

unread,
Apr 30, 2010, 1:45:33 AM4/30/10
to bl...@googlegroups.com

Comment #3 on issue 37 by masayan68: first letter of link was not encoded.
http://code.google.com/p/gwtwiki/issues/detail?id=37

Thanks so match!

gwt...@googlecode.com

unread,
May 13, 2010, 11:44:52 AM5/13/10
to bl...@googlegroups.com
Updates:
Status: Fixed

Comment #4 on issue 37 by axelclk: first letter of link was not encoded.
http://code.google.com/p/gwtwiki/issues/detail?id=37

(No comment was entered for this change.)

--
You received this message because you are subscribed to the Google Groups "Bliki - Java/Eclipse Wikipedia API" group.
To post to this group, send email to bl...@googlegroups.com
To unsubscribe from this group, send email to bliki-un...@googlegroups.com
For more options, visit this group at http://groups.google.com/group/bliki?hl=en
or visit the projects homepage at http://code.google.com/p/gwtwiki/
Reply all
Reply to author
Forward
0 new messages