Bug fixes to latest - svn/branches/B5X B56a7 (3825)

[Paul Kohut]

I've compiled the latest available source and fixed it so the
"Services Menu Module"
can be downloaded and installed to B56a7 (at least on 10.5.8 and
10.6.1).
As far as I can tell it is working fine, like ...
put some text in first pane, type "look" in second pane, press
enter dictionary definition appears.
put URL in first pane, type "shrink" in second pane, and get back
a TinyUrl.
... however, I'm very new to QS and don't know how it is suppose to
"work".

What is the procedure for submitting these fixes back to the
Quicksilver project?

Also, there appears to be a newer version of the Services Menu plugin
located at
http://blacktree-elements-public.googlecode.com/svn/trunk/Services/
Although it compiles and installs (without crashing) on B56a7, it
doesn't work.
So I fixed this one also, and would like to submit those changes back
too.

TIA, Paul

[Eris]

Wow, sounds great. I'm not sure how useful the services menu plugin
would be to me on Snow Leopard, but I know a lot of people miss it and
will be glad to have it back, so on behalf of everybody else, thank
you.

Have you tried contacting Etienne directly about commit rights? He
seems to be the one in charge, although I haven't seen him around
recently.

On Oct 30, 1:18 pm, Paul Kohut <pkoh...@gmail.com> wrote:
> I've compiled the latest available source and fixed it so the
> "Services Menu Module"
> can be downloaded and installed to B56a7 (at least on 10.5.8 and
> 10.6.1).
> As far as I can tell it is working fine, like ...
>     put some text in first pane, type "look" in second pane, press
> enter dictionary definition appears.
>     put URL in first pane, type "shrink" in second pane, and get back
> a TinyUrl.
> ... however, I'm very new to QS and don't know how it is suppose to
> "work".
>
> What is the procedure for submitting these fixes back to the
> Quicksilver project?
>
> Also, there appears to be a newer version of the Services Menu plugin

> located athttp://blacktree-elements-public.googlecode.com/svn/trunk/Services/

[Paul Kohut]

Thanks. I'll fire off an email.

[JiveMasterT]

Can you describe what you did to build a working copy of QS? I've
compiled the app from source several times but it either doesn't work
at all, or it doesn't launch applications when I finally do get it to
work.

[nontoppo]

Thank you Paul for your contribution! Look forward to seeing it rolled
in to the source tree...

[Paul Kohut]

I've posted the patch to -
http://code.google.com/p/blacktree-quicksilver/issues/detail?id=126
The patch will allow you to download and install the SMM plugin
just like in the B54 days.

And here a patch to fix the SMM source code available at
http://code.google.com/p/blacktree-elements-public/issues/detail?id=1.
This is not needed if you download your plugin from within QS.

[Paul Kohut]

After downloading the source code the only changes made was
to update the Configuration/Developer.xcconfig file, so that
QS_SOURCE_ROOT = ~/Documents/XCodeProjects/Quicksilver/B5X/Quicksilver
(Change the directory to reflect your directory structure)

In XCode->Preferences->Source Trees add an entry
for Settings Name = QSFrameworks and Path = /Applications/
Quicksilver.app/
Contents/Frameworks/
(Actually, just checked and QSFrameworks is not referenced anywhere
for
the B56a7 (3825) projects. Deleted it and did a clean rebuild
worked ;-) )

Without seeing a build report I couldn't tell you why it may or may
not be
compiling. With the settings above the release I386 build compiles
with
76 warnings and 0 errors (compiled from Xcode 3.1.4 on 10.5.8, I386).

[andreb]

Thanks again for the patch Paul.

Yeah the QSFrameworks dependency seems stale... oh well, I am keeping
it around for now.

@JiveMasterT

I have described the steps needed to setup Xcode for building QS on my
github page:

http://github.com/andreberg/Quicksilver-B5X

HTH

André

[Paul Kohut]

Site looks good André. How often do you plan to release new binaries?

[elspub]

We patch the source ourselves? Or downlad the plugin from the
preference pane?

[Patrick]

If you want any changes committing to the repository, let me know and
I can commit them.

I don't have the power to add people to the group, it's just jnj that
can do that.

I asked jnj to add me to the elements-public group but he never got
back to me. I'd suggest getting in touch with Etienne if we want
something committing to that repository.

[Paul Kohut]

Thanks Patrick. I'll 'cc you for any future updates.

[Etienne Samson]

I just sent a email to Andreb regarding commit access : I would prefer
switching to git and GitHub, since it would relieve me from manually
managing commiters, and allow me to see what others people are
currently up to. I'll try to keep the Google Code Subversion up to
date for the foreseeable future.

Thus, I created the following repositories, which mirrors the ones we
have on Google Code :
http://github.com/tiennou/blacktree-alchemy
http://github.com/tiennou/blacktree-elements

Feel free to send pull requests my way ;-).

@Paul : I'm likely to integrate both patches to QS this week, unless
you happen to fork and "recreate" (in the sense of applying your
changes) quickly enough ;-). Thanks for the fix !

Etienne

[elspub]

the current binary on the github seems to fix a lot of the snow
leopard glitches, and is faster too.

Thanks andreb, paul, etienne, and whoever else is active in keeper QS
alive and kicking...

[Tim]

Can someone please let me have the url for the binaries - I'm going to
take the plunge and give this a shot, having downloaded xcode etc.
I'm presuming that's the first prerequisite for doing so...?

Any other hints / tips for building would be very gratefully received
since I'm new to this sort of thing.

TIA
Tim.

[elspub]

It's at the github that andreb posted about (comment #6) the download
link is this: http://github.com/andreberg/Quicksilver-B5X/downloads

[Patrick]

Woops!

I've been updating the QS code like a fool!

I'll look over at the github repository :D

[andreb]

If you just want to try the GitHub version out there's no need to
install Xcode just for this.
As elspub says I have also posted a downloadable binary.

I am currently working on integrating my GitHub repo with the soon-to-
be official GitHub repo Etienne set up.
As our commit SHAs differ I will need to go through each on and lay on
hand on the stuff that doesn't merge cleanly
(which is almost all commits since I haven't really added much - just
changes).

I should probably mention this fact on my repo's tagline before we see
forks from my one - which really isn't good at this point in time.

And, yeah, it feels good to see someone reporting improvements. :)

Etienne brought me onto really using Git. It's such an improvement
using it and GitHub for collaboration.
I think Quicksilver and the way multiple devs working over the net is
the perfect type of project for Git and GitHub.

Another thing I am really enjoying is LLVM/Clang.
Apple and their contributors have done such an amazing with this new
compiler it almost feels unreal.

André

[Paul Kohut]

Have you gotten a clean compile with LLVM/Clang? I just tried and get
about a hundred compiler errors. Most of the errors occur on some bad
programming practices, so a little refactoring will fix them right
up.

[Tim]

André -

This build is working great for me on SL - very many thanks to you.
One thing I've noticed, just FYI, is that the 'light' under the dock
icon doesn't appear even when QS is running...

[Etienne Samson]

Hi André !

I have some good news for you. I already did the conversion (moved
your commits on top of my branch), so if it's good for you, I can pull
all your changes to blacktree-alchemy, then you'll just have to fork.

I also looked a little at the state of the Airport Module, and the
situation is dire. We're using Private APIs for this, and there were
heavily changed on SL (Look up Apple80211.h), and now the one we have
now returns an error, and the Airport Module just call exit() if it
fails...

Etienne

[Rob McBroom]

On Nov 7, 2009, at 5:46 PM, andreb wrote:

> If you just want to try the GitHub version out there's no need to
> install Xcode just for this.
> As elspub says I have also posted a downloadable binary.

Thanks to you (and everyone else) for the work. It's nice to see some
progress. What's the preferred way to report issues with this release?
Doesn't seem appropriate to report them on Google code, since they
don't apply to the code that's there. Thanks.

--
Rob McBroom
<http://www.skurfer.com/>

Because it screws up the order in which people normally read text.

Original message:

> Why is it bad to top-post your reply?

[andreb]

@Etienne

That is good news indeed. I was getting nowhere with a commit (I must
have been doing something wrong in the process up to then or it is
because I didnt fork directly but added a remote and fetch) and had to
put it on the backburner because I have been booked for a freelance
job.

So, sure if you already have all my commits on top of yours there's no
point in me doing the same. I can fork or pull from you then.
If you don't mind, can you include my README.markdown for GitHub?
I think having some more explanation about building in there helps new
devs such as myself. Throw the legal bit out if clashes with QS'
existing paradigm.

@Paul Kohut

"Have you gotten a clean compile with LLVM/Clang?"

IIRC, not at first. I had to work quite a few changes but Clang's
error messages are superior to GCC and also can show you the exact
location the error is in the line which was helpful.

We are still at around 125 warnings though. Most are still deprecation
stuff and stuff from the NTViewLocalizer which would confuse any
compiler.
I dont't think we can get rid of those (other than trying Clang's
awesome ability to disable/enable a specific warning on a per file and
per-line basis).

About your build errors:
Keep in mind that you need to make sure that each xcconfig file is
used for the correct build configuration (you know the little dropdown
at the lower right of the build settings dialog).
Sometimes Xcode forgets what was asigned to what build configuration
especially if you duplicate a configuration or make a new one. I could
imagine that's where your build errors are coming from. If not there
are two settings that seem to influence the build differently than
GCC. I think one is the Always Search User Paths. The other I can't
remember but it has to do with where the pre-compiled headers are
stored for the frameworks leading to Clang thinking there is code
duplication (lotsa "... already defined" errors).

I think I put a few comments regarding the Clang build stuff inside
the Developer.xcconfig on my repo. I can't take a look right now
because I am at a work computer provided by someone else.

@ Rob

I guess the preferred way of posting issues may now be over at
github.com/tiennou/blacktree-alchemy under the Issues tab.
Or we just continue the issues tracker over at Google Code. It's
really Etienne's decision as Etiennie's repo now will be the main one
once again. Personally I wouldn't mind continuing at GC but I wouldn't
underestimate having the code and the issue tracker in one place.


Cheers,

André

PS. As I am working the freelance job I may be unable to respond
properly or look into stuff for days even. We'll see how it goes.

[andreb]

@Tim

That is interesting. It does seem to appear in my dock though I never
have the option to show QS in the dock enabled.
Maybe it helps if you disable the icon, relaunch, re-enable the icon
and relaunch again?
Other than that I haven't touched any code that would disable/enable
dock icon at runtime.

Anyway, glad to see that this build works for you.

[kvn]

I actually had the same problem like Tim. What's causing it is that
somehow the 'show icon in dock' option does get unchecked after
replacing Quicksilver with your build and the icon is still there as a
"left-over". After rechecking it and restarting Quicksilver it's fine
though.
I also enjoy your build, I noticed that when I move around files now,
QS comes back up with the file I just moved (moving files is really
much more stable with your build!). Not a biggie but I wonder if I can
disable that somehow?

[Etienne Samson]

Le 10 nov. 2009 à 10:56, andreb a écrit :

> @Etienne
>
> That is good news indeed. I was getting nowhere with a commit (I must
> have been doing something wrong in the process up to then or it is
> because I didnt fork directly but added a remote and fetch) and had to
> put it on the backburner because I have been booked for a freelance
> job.
>
> So, sure if you already have all my commits on top of yours there's no
> point in me doing the same. I can fork or pull from you then.
> If you don't mind, can you include my README.markdown for GitHub?
> I think having some more explanation about building in there helps new
> devs such as myself. Throw the legal bit out if clashes with QS'
> existing paradigm.

Done. Had a hard time with cherry-picking though ;-). There's two
commits I didn't include : bc7e2f323d5eae6162a1f43ac97d18b2e51547c5
and 9a56476e6dbe6d5fe48bdf35914fd6a005dcac8b, since GitHub is now our
common repo. No problem with the License, we're under Apache License
v2 anyway (if you ignore the old headers in source files ;-)).

> We are still at around 125 warnings though. Most are still deprecation
> stuff and stuff from the NTViewLocalizer which would confuse any
> compiler.

Quick note about NTViewLocalizer: ...which is utterly useless, as far
as I can remember. It's used for on-the-fly translation of the
interface (as in, no need to duplicate every NIB file for every
localization), but it's not used since it's main entry point is
currently disabled.

> @ Rob
>
> I guess the preferred way of posting issues may now be over at
> github.com/tiennou/blacktree-alchemy under the Issues tab.
> Or we just continue the issues tracker over at Google Code. It's
> really Etienne's decision as Etiennie's repo now will be the main one
> once again. Personally I wouldn't mind continuing at GC but I wouldn't
> underestimate having the code and the issue tracker in one place.

The GC issue tracker is a pain for me. People add reports but nothing
tells you they just did, so they sit along, waiting for me to batch-
assign them to me. People can't change the state of issues. Multiply
all this with the fact that non-developer _love_ duplicate reports...
I'm pretty sure I'll love the GitHub tracker, though I haven't used it
yet.

Etienne

[andreb]

@kvn

Sorry, not really, as that is actually a feature. :)

One would have to implement a preference for that.
I am sure we can all agree that we should focus on fixing the issues
QS has right now before adding any more stuff that can add to
debugging complexity.
Also, as you mention yourself, it's no biggie when all you need to do
is hitting 'Esc' after the move is complete.
Work items like that will inevitably have a low priority for some time
to come.

Your clarifying words about the dock icon glitch remind me of another
important issue I forgot to mention in the README:

If you want to use the global services hotkey (Cmd+Esc) that QS brings
with it you need to make sure that no two instances of Quicksilver.app
which define the same service with the same hotkey in their Info.plist
can be found and indexed by /System/Library/CoreServices/pbs (which
is pretty much anywhere on your system as it works like Spotlight). If
you want to keep older Quicksilver.app packages zip them and delete
the .app folder structure of the QS you no longer need (and don't
forget to empty your recycle bin after that).

The global services hotkey makes it work that you can select anything
in any app and invoke QS which then tries to interpret the selection
(e.g. text, files, folders, images, colors etc.). It works in tandem
with the "Pull selection from frontmost app instead of Finder"
preference item under Extras.

[Tim]

Yep - should have said, so very sorry. I removed the icon from the dock (dragged it off the dock) and then went into the QS prefs pane (now that it shows up in your 3838 build, André) where I noticed that the option to show it in the dock was unchecked. Checking it returned the normal / expected behaviour.

On an entirely different tack, can we expect new builds of the QS.app (the app not the source code) to be made available on the github from time to time as things progress? If so, at which location - 'andreberg' or 'tiennou'? And how would notification of such builds be made?

Finally (for the moment at least) - I'd like to express my sincere and heartfelt thanks to everyone who's going to such efforts to make QS compatible with SL. It's an indispensable app. to me (I much prefer it to LaunchBar).

Tim.

[Andre Berg]

@Tim

No need to be sorry mate :)

It is particularly easy to post binaries to GitHub but that is entirely up to the repo owner. I would do the following:

Check tiennou/blacktree-alchemy Downloads tab and look at the date of the last item posted. 

Check andreberg/blacktree-alchemy Downloads tab look at the date of the last item posted. 

Download whichever is more recent. Probably goes without saying but remember to always backup your data first. 

Details are in the README.markdown about that.

Now this is important:

Development will happen distributed as this is the nature of Git. Etiennes repository (tiennou/blacktree-alchemy) will be the main one from which all other developers will download a repo copy ("fork" in git speak) and do their changes on their own copy. When satisfied with their changes developers will ask Etienne to pull from their fork which incorporates the new changes into Etienne's repository. 

Etiennes repository should always be (in the end) the one which has all changes so this should be your first address to check. It can of course happen that my fork or any other devs fork appears to be newer because I haven't asked Etienne to pull from me yet. That's why I gave the order above.

NOTE: This also means that effective immediatly github.com/andreberg/Quicksilver-B5X is obsolete and I may delete this repo in the future. 

As said I will continue my development on my fork of Etienne's repo (where he already was so kind to do the work I should have done and incorporated my changes of github.com/andreberg/Quicksilver-B5X) at github.com/andreberg/blacktree-alchemy.

This also means that issues should now be posted at github.com/tiennou/blacktree-alchemy. I will post the issues I have recieved at github.com/andreberg/Quicksilver-B5X over at Etienne's repo if the Issue owners don't do it themselves.

I know this is a bit confusing but we will get behind this :) Took me quite a while to figure out Git too. But once your on top of things it really is so much better for exactly our kind of project.

André

2009/11/10 Tim <stati...@gmail.com>

[Tim]

Gotcha, André but I have just one outstanding query:  I don't know how to go about compiling / building the app from the binaries I've downloaded.  Is Clang a command line thing (at which point I don't want to go any further!) or is it a downloadable app with a nice, pretty GUI?  If the latter, I don't mind trying to get my head around it.

I have got XCode because I have it mind to try to write a simple (but useful) iPhone app one day when I get the time.  I tried to build QS using your binaries with that but got loads of errors.

All that said, if periodic (say, weekly or fortnightly) builds of the app itself could be made available on github, that would be great for the non-tech likes of me!

Tim.

[andreb]

@Etienne

Thanks a lot for doing the work I should have done ;)
You're absolutely right about not including the two commits.

Also thanks for clarifying stuff about the NTViewLocalizer.
Took me quite a while to figure what it was actually doing because it
looked a lot like smoke and mirrors lol.

I didn't know that GC's issue tracker was such a pain to manage.
Let's use your issue tracker over at github.com/tiennou/blacktree-
alchemy then.

I allowed myself to re-create three issues there which I had recieved
at Quicksilver-B5X.
The names of the original owners are mentioned at the end of issue
body.

André

[andreb]

@Tim

Sure I can post binaries. But I don't really think in time frames.
When I develop in my sparetime it happens in spontaneous bursts.
There may even be longer periods where I can't do anything at all
until I am out of a freelance job.
Longest freelance job I had was half a year ;) And that was 18hr
double pressure half a year :)

But let me say that there isn't much point in trying to build QS
merely to get a workable binary. I don't think that should be the job
of the users.
It makes more sense in my book to post binaries when we have fixed
another issue. Posting nightlies or regularly timed binaries is ok for
projects like Firefox where really a lot happens during one day.
For QS with its handful of devs this just places too much unneeded
strain on the devs. Unneeded because there may not even be that much
that has changed.
Most likely you won't feel difference if we would adopt nightlies.

That said I will try to post a binary of the current state later on.

Anyway about Clang. It's a compiler already integrated into Xcode. In
Xcode you can adjust certain settings to tell it which compiler to
use.
Clang is already the default compiler of the source code you
downloaded.

Mastering compiler error messages and Xcode's tripple cascading build
settings system can be tough if you're just starting out.
I know the feeling :)


André

On 10 Nov., 19:16, Tim <stationf...@gmail.com> wrote:
> Gotcha, André but I have just one outstanding query:  I don't know how to go about compiling / building the app from the binaries I've downloaded.  Is Clang a command line thing (at which point I don't want to go any further!) or is it a downloadable app with a nice, pretty GUI?  If the latter, I don't mind trying to get my head around it.
>
> I have got XCode because I have it mind to try to write a simple (but useful) iPhone app one day when I get the time.  I tried to build QS using your binaries with that but got loads of errors.
>
> All that said, if periodic (say, weekly or fortnightly) builds of the app itself could be made available on github, that would be great for the non-tech likes of me!
>
> Tim.
>
> On 10 Nov 2009, at 17:58, Andre Berg wrote:
>
>
>
> > @Tim
>
> > No need to be sorry mate :)
> > It is particularly easy to post binaries to GitHub but that is entirely up to the repo owner. I would do the following:
>
> > Check tiennou/blacktree-alchemy Downloads tab and look at the date of the last item posted.
> > Check andreberg/blacktree-alchemy Downloads tab look at the date of the last item posted.
>
> > Download whichever is more recent. Probably goes without saying but remember to always backup your data first.
> > Details are in the README.markdown about that.
>
> > Now this is important:
>
> > Development will happen distributed as this is the nature of Git. Etiennes repository (tiennou/blacktree-alchemy) will be the main one from which all other developers will download a repo copy ("fork" in git speak) and do their changes on their own copy. When satisfied with their changes developers will ask Etienne to pull from their fork which incorporates the new changes into Etienne's repository.
> > Etiennes repository should always be (in the end) the one which has all changes so this should be your first address to check. It can of course happen that my fork or any other devs fork appears to be newer because I haven't asked Etienne to pull from me yet. That's why I gave the order above.
>
> > NOTE: This also means that effective immediatly github.com/andreberg/Quicksilver-B5X is obsolete and I may delete this repo in the future.
> > As said I will continue my development on my fork of Etienne's repo (where he already was so kind to do the work I should have done and incorporated my changes of github.com/andreberg/Quicksilver-B5X) at github.com/andreberg/blacktree-alchemy.
>
> > This also means that issues should now be posted at github.com/tiennou/blacktree-alchemy. I will post the issues I have recieved at github.com/andreberg/Quicksilver-B5X over at Etienne's repo if the Issue owners don't do it themselves.
>
> > I know this is a bit confusing but we will get behind this :) Took me quite a while to figure out Git too. But once your on top of things it really is so much better for exactly our kind of project.
>
> > André
>

> > 2009/11/10 Tim <stationf...@gmail.com>

[Tim]

André -

NOW I understand! Thank you! I'm really very happy at the moment with your 3838 build so please don't go to any trouble on my account unless and until you think a fresh build is truly worthwhile.

Thanks also for your explanation of Clang. I'm feeling bowed over by all this so... I'm giving up for the day and going for supper!

Cheers buddy!

Tim.

[andreb]

Ok binary for rev 3839 is up at http://github.com/andreberg/blacktree-alchemy/downloads

Also for people still on 10.5 the source should now build ;)

André

[Tim]

Thanks André. For me, using 10.6.2, when I install this build (3839) I can launch QS but when I invoke it, I just get a 'bonk' sound. I also see it's hosed my triggers. Not a biggie for me since I backed up per your advice (and I backup regularly anyway), but thought you should know.

Even if I quit QS 3839, replace the ~/Library/Application Support/Quicksilver and ~/Library/Caches/Quicksilver folders with the ones from my backup and relaunch the same thing happens. I know its build 3839 doing it because if I revert to 3838 the triggers are still missing until I once more replace from the backup - particularly the App. support one of course. After that, everything is 'normal'.

Tim.

[elspub]

I experienced the exact same with 3839.

[andreb]

Oops, can you verify that the PlugIns folder is missing inside
Quicksilver.app ?
It appears the build process did not include it this time.
The PlugIns folder contains all embedded actions like CoreSupport and
the Bezel and Primer interfaces.
If they are missing QS can't show a window.
It seems I have posted the wrong version (an intermediary build
product).
Apologies for this mistake. Will correct it with the version that is
working for me.

Just needed some sleep that is all ;)

[andreb]

Ok replaced it. I did download it and made sure that the Contents/
PlugIns really is a folder inside Quicksilver.app which has

Bezel Interface.qsplugin
Core Support.qsplugin
Finder Module.qsplugin
HotKey Triggers.qsplugin
Primer Interface.qsplugin

in it. Enjoy (this time anyway).

And I do hope y'all had backups so you didn't loose any data.

If against all odds it isn't working the other version you were
running previously is always available as binary from the new repo
too.

[Tim]

Correct André. Is it simply a case of copying the plugins folder from within the 3838 build to the same place in the 3839 build and hey presto! off we go again?

By the way, I thought devs didn't need sleep - am I wrong? ;-)

Tim.

[Tim]

Thanks André - issue fixed.

[andreb]

Yes in that case this would have sufficed.

Maybe if I try to think like a machine long enough I will become one
and can get rid of this nastyness that is called sleep.
Hey, then I can go out with Seven of Nine.

[elspub]

Maybe this Google Group should have a new page for discussion on the
github builds... Right now its all happening in the depths of this post