Issue #39 - web search module

[Patrick]

Refer to http://github.com/tiennou/blacktree-alchemy/issues#issue/39
for initial posts.

The bug seems to have started around commit 034198f

To build anything before that you need the NSImage+QuickLook folder.

Paste the attached file in ROOT/Quicksilver/Code-External/

[Patrick Robertson]

2010/1/7 Patrick <robertso...@gmail.com>

[Patrick]

P.S. this is mainly for the eyes of pkohut. Whoever has the power, can
you add him to the group please :)

On Jan 7, 2:10 pm, Patrick Robertson <robertson.patr...@gmail.com>
wrote:
> 2010/1/7 Patrick <robertson.patr...@gmail.com>
>
>
>
> > Refer tohttp://github.com/tiennou/blacktree-alchemy/issues#issue/39

> > for initial posts.
>
> > The bug seems to have started around commit 034198f
>
> > To build anything before that you need the NSImage+QuickLook folder.
>
> > Paste the attached file in ROOT/Quicksilver/Code-External/
>
>
>

>  NSImageQuickLook.zip
> 2KViewDownload

[Paul Kohut]

I just tested the B54 dmg from blacktree.com on 10.5.8 and it has the
same problem. So I'm at a loss to find a working version to compare
against.

If anyone has a PPC or earlier versions of 10.4 / 10.5 to test against
that would be great, as it's possible something broke with one of the
Leopard updates.

[Howard Melman]

I've seen this issue occasionally, so it must be in B54. I think this may have something to do with where in the catalog the url comes from. It might be fine from say a local web search catalog item but not from the default web hosted list of searches. Or maybe it works from bookmarks but not browser history. You can also try using qss-http: or http: to see if that makes a difference.

Howard

[Paul Kohut]

Thanks Howard. I'm pretty sure the favicon issue is in the Safari
Plugin. It's
actually trying to load icons from ~/Library/Safari/Icons/ which does
not
appear to exist on my system, while a SQLite db exists called
WebpageIcons.db.
Possibly, if the Safari Plugin is updated to include the db source
then favicon
would fix itself. For those that don't use Safari, then they're
missing out.

But, there seems to also be another issue with the Web Search Plugin
and the
http://docs.blacktree.com/doku.php?id=quicksilver:web_search_list URL.
imageNamed in QSResourceManager.m, never resolves the URL with an
image
pointer, so it is being displayed blank (even though
displayIconForObject in
QSObject_URLHandling.m is suppose to handle it).

Also, trying to debug functions like displayIconForObject, that make
calls to
NS_INLINE'ed functions, is extremely difficult to do. See this for
more details
http://stackoverflow.com/questions/1895663/nsinline-and-xcode-debugger
I welcome any and all suggestions to try and resolve that.

Despite the debugger issues though, I've written a new fix for
handling the
web_search_list URL, which shows a composite image with the Finder
icon
overlay, both in the first panel and the dropdown list. I'll get that
code out soon
so others can review it.

Now, if the favicon issue can be resolved then that would just be
icing on the cake,
so to speak. One option is to fix the Safari Plugin and add the same
support
to the Firefox plugin. Another option is to use Google's favicon
cache to retrieve
them when needed. Here's some samples.

http://www.google.com/s2/favicons?domain_url=http://www.lifehacker.com/
http://www.google.com/s2/favicons?domain_url=http://www.apple.com/
http://www.google.com/s2/favicons?domain_url=http://groups.google.com/

I think the first option is better overall, because the icons are on
local storage already
cached by Safari / FF. Also, the Google s2 cache is not always the
same icon
as determined by a web browser. Look at the favicon for www.googlegroups.com
and look at the s2 cached icon.

TIA,
Paul