[Blacklight-development] [#CODEBASE-217] Move document list logic into a helper

3 views
Skip to first unread message

Chris Beer

unread,
May 3, 2010, 5:24:13 PM5/3/10
to blacklight-...@googlegroups.com
I just submitted a JIRA ticket and patch to move the document_list partial rendering function into a helper function, to make it easier to override this behavior for local installs. See <http://jira.projectblacklight.org/jira/browse/CODEBASE-217>. This is c9e695efba7fc4aa69d2.. 7cf0382da5e1c2bf90a9 from my github branch http://github.com/cbeer/blacklight/commits/local-customizations-support

It doesn't look like rspec tests for render_document_list_partial are possible, as rspec doesn't support testing 'render' calls from helpers, unless anyone knows differently. The only test supplied, then, ensures the document_list_partial helper returns a string. Are further tests necessary/possible?

Thanks,
Chris Beer
WGBH Interactive



[1] <http://www.mail-archive.com/rspec...@rubyforge.org/msg12858.html>

--
You received this message because you are subscribed to the Google Groups "Blacklight Development" group.
To post to this group, send email to blacklight-...@googlegroups.com.
To unsubscribe from this group, send email to blacklight-develo...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/blacklight-development?hl=en.

Reply all
Reply to author
Forward
0 new messages