Test Fixtures Management

[Sidney Zhang]

https://github.com/cryptocoinjs/btc-transaction/blob/master/test/transaction.test.js#L14

https://github.com/cryptocoinjs/btc-script/blob/master/test/script.test.js#L69

The above are some of the examples of fixtures that we need across all of the modules' tests. 

I feel like it would be good to have a central place to combine these fixtures and reuse them.

I want to get your thoughts on these

[JP Richardson]

Good thought. How about the Wiki in the cryptocoin Github repo? We could start a new document called `Test fixtures` or something like that. 

--
You received this message because you are subscribed to the Google Groups "Bitcoin Hackers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to BitcoinHacker...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

--
Follow me on Twitter: http://twitter.com/jprichardson

[Sidney Zhang]

I was actually going to suggest that we could have a module called btc-fixtures

In that module, we could keep all kinds of fixtures in there and would probably really help other developers too.

For example: in order to test serialize() or deserialize

We need the hex for

coinbase transaction

pubkeyhash transaction

scripthash transaction

pubkey transaction

op_return transaction

nulldata transaction

escrow transaction

The same applies to script etc. Might be useful as a module or a separate repo

[JP Richardson]

I like this idea much better!

[Sidney Zhang]

Also need to test for all the mutated transactions due to the malleability bug

[Sidney Zhang]

Something like this might be appropriate

https://github.com/bitcoin/bitcoin/blob/master/src/test/data/script_invalid.json

Kind regards,

Sidney Zhang

Mobile: +1 415 767 8831