Add importprivkeys RPC

[blocktraveler]

Hy there!

Unfortunately, the PRs are locked, so I'm sharing my thoughts this way.

Over the years, people have asked countless times on various platforms how to import private keys (both legacy and Bech32/SegWit) into a Bitcoin Core descriptor wallet. This issue is especially common in Namecoin. I see no reason why importing private keys, a very basic feature, should be restricted to the point that it's impossible for the average user to succeed. That's why I created the Core-Wallet-Migration-Tools in Python.

However, it would be much easier to have an 'importprivkeys' RPC for descriptor wallets (not to be confused with the legacy 'importprivkey' call). Pls check my initial thoughts:

Proposal: Add importprivkeys RPC (helper for WIF → descriptor import)

Thx!
Uwe

[Email para newsletters]

IMO thats a very good proposal and should be really easy to implement.

Allow me to share some points.

* The return scheme somewhat extends the one from the already existing `importdescriptors`. This can be considered a corner to cut if theres implementation burn.

* I do not have any idea about others opinion but I consider a flaw to not have a checksum induction flag in `importdescriptors`, which could reduce `importprivkeys` command dependency as well extending them both.

Best,
Joao Leal

--
You received this message because you are subscribed to the Google Groups "Bitcoin Development Mailing List" group.
To unsubscribe from this group and stop receiving emails from it, send an email to bitcoindev+...@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/bitcoindev/ad14b140-9e02-466c-8226-304ec651f4ben%40googlegroups.com.

[blocktraveler]

Hy and thx for the feedback, much appreciated!

* Regarding return scheme: Sure, redundant or competing returns should be unified. The question is, at which point the 'importprivkeys' call could just proxy or complement the return of the 'importdescriptors' routine.

* Regarding checksum flag: Good point as well. Adding an 'auto_checksum' boolean to 'importdescriptors' would simplify things. Not sure if this has been discussed before or in case, what was the reason for not implementing it.

Happy to address this in the proposal or the PR.

Best regards,
Uwe