GammaDiscreteRateDistribution: issue in the constructor
11 views
Skip to first unread message
Jean-Baka Domelevo Entfellner
Feb 13, 2013, 8:03:55 AM2/13/13
to biopp-he...@googlegroups.com
Hi all,
In the constructor for GammaDiscreteRateDistribution objects, there is a mistake, imho: the value of 1.0 for alpha (shape parameter) is just a default one, and the user is allowed to specify a different one. But this is discarded on line 54 of file Bpp/Phyl/Model/RateDistribution/GammaDiscreteRateDistribution.h, where the current code calls the base class as:
GammaDiscreteDistribution(nbClasses, 1., 1.)
and it should be:
GammaDiscreteDistribution(nbClasses, alpha, alpha)
Cheers,
Jean-Baka
Laurent Guéguen
Feb 14, 2013, 8:09:45 AM2/14/13
to Bio++ Usage Help Forum
Hi Jean-Baka,
yes indeed, I fix it.
Thanks,
L
On Feb 13, 2:03 pm, Jean-Baka Domelevo Entfellner <domel...@gmail.com>
wrote:
yes indeed, I fix it.
Thanks,
L
On Feb 13, 2:03 pm, Jean-Baka Domelevo Entfellner <domel...@gmail.com>
wrote:
Reply all
Reply to author
Forward
0 new messages