UserAlphabetIndex1: incorrect usage not halted?

[Keren Halabi]

Hi dear team,

I have notices something peculiar in the class UserAlphabetIndex1: it always decrements 1 from the returned index of her corresponding data member alph_.

This property appears to be problematic when the the state is a gap (i.e., -1) in which case its index is 0 and so this decrement results in attempts to access negative, illegal, index -1.

Maybe this is something that should be avoided to begin with? Is there a reason for this decrement? 

Many thanks!

Keren

[Laurent Guéguen]

Hi Keren,

I agree this should not be the case, I remove the decrements.

Cheers,

Laurent

[Julien Y. Dutheil]

Hi,

This is strange, this minus 1 was not part of the original class, it was introduced later on... there must have been a reason :s ?

J.