clonable tree Nodes

[Laurent Guéguen]

Hi,

I want to exploit the clonability of some objects in a Tree.
Is it fine with any of you if I change TreeTemplateTools.h like this?

template<class N>
  static N* cloneSubtree(const Node& node)
  {
    // First we copy this node using default copy constuctor:
    N* clone;

    // previous version :  clone = new N(node);

    if (dynamic_cast<const Clonable*>(&node)==0)
      clone = new N(node);
    else
      clone = dynamic_cast<const N*>(&node)->clone();
   

    // We remove the link toward the father:
    // clone->removeFather();

    // Now we perform a hard copy:
    for (int i = 0; i < static_cast<int>(node.getNumberOfSons()); i++)
    {
      clone->addSon(cloneSubtree<N>(*node[i]));
    }
    return clone;
  }



Or is there a problem I missed?

Cheers,
Laurent

[Julien Yann Dutheil]

Definitely fine and needed. I cannot see any issue with that.

J.