Reaction now uses AddOns-fork and has test-coverage reports

1 view
Skip to first unread message

Sergey Schetinin

unread,
Nov 11, 2009, 5:49:20 AM11/11/09
to Better Python
Hi everybody,

I've just committed a change that makes Reaction use AddOns-fork
(http://bitbucket.org/mlk/addons-fork/). The reason for that (and for
creating a fork) is that AddOns was using decoratrotools' decorate()
hack. That function allows to precede functions w/ the decorators on
old Python versions where docrator syntax is not available. It's
accomplished via sys.settrace and was interfering with test-coverage
reporting (http://nedbatchelder.com/code/coverage/). So Addons-fork is
the same thing as AddOns w/o the limitation (it's imported from the
same location).

If you want to check out the coverage report, checkout the latest
reaction, remove addons from your system (by deleting the egg from
site-packages) and then call "setup.py develop" in Reaction checkout.
Next just run test.py and you'll get a coverage report in
_coverage_report subdirectory.

Turns out we have a decent coverage with 92% of the library code
getting to run during the tests. That doesn't guarantee that all
scenarios are covered, but that's still good.

(On the issue of forking yet another PJE's library I have a couple of
patches to AddOns that I've submitted to PEAK list I think two years
ago and Phillip didn't even acknowledge them, so I'm pretty sure
forking is the way to go.)
Reply all
Reply to author
Forward
0 new messages