Issue #221: Hardcoded '/' in tests leads to widespread test failure on Windows (blais/beancount)

24 views
Skip to first unread message

Jeff Brantley

unread,
Feb 26, 2018, 12:33:19 AM2/26/18
to bean...@googlegroups.com
New issue 221: Hardcoded '/' in tests leads to widespread test failure on Windows
https://bitbucket.org/blais/beancount/issues/221/hardcoded-in-tests-leads-to-widespread

Jeff Brantley:

Although the beancount codebase and tests do take advantage of os.path.join, lots of tests have hardcoded forward-slash ('/') path separators, particularly in expected-value regex strings. I'm not sure whether there are any failure cases due to trying to *use* a Unix-style path.

Steps to Reproduce:

Generally follow what the Installing Beancount doc says Martin does for development, but map it to Windows:

1. Install python and pip-install dependencies manually, including nose
2. Optionally work in a virtual environment using `python -m venv ENV && ENV\Scripts\activate`
3. cd to beancount repo and run `python setup.py build_ext -i`
4. cd elsewhere, I guess
5. `set PATH=%PATH%;C:\path\to\repo\bin`
6. `set PYTHONPATH=%PYTHONPATH%;C:\path\to\repo`
7. `nosetests -v beancount`

To assess and experiment with failing tests "one-at-a-time", one (probably non-optimal) way is to run with `-x` to stop on first failure, and then progressively add in `-e TESTNAME` flags to skip individual failing tests in order to get to the next failure. The first failing test will not necessarily be failing due to this issue.


Reply all
Reply to author
Forward
0 new messages