beancount.el: Add option `beancount-accounts-files'

65 views
Skip to first unread message

Yiufung Cheong

unread,
Nov 9, 2019, 12:22:20 AM11/9/19
to Beancount
I usually dedicate an "accounts.bean" to declare all my accounts, and do my daily financing in another file. Currently `beancount-insert-account`(C-c ') only read candidates from current buffer, so it's inconvenient. This patch adds an option to allow user to specify a bunch of files to read completion candidates.

Newly added `files' argument is optional, so won't affect current users. Similar things could be done for links / tags by adding related options, but I left it to your judgment whether it's necessary.


beancount-accounts-files.patch

Martin Blais

unread,
Dec 25, 2019, 11:39:56 PM12/25/19
to Beancount
Hi Yiufung,
Sorry for delays, I'm on vacation now, finally getting to chug through
my personal email after a busy quarter.
Just had a quick look; beancount.el has been updated since you sent this.
Could you send me a pull request and make sure the tests pass?
Happy to have a look.
Thanks,


On Sat, Nov 9, 2019 at 12:22 AM Yiufung Cheong <cheong...@gmail.com> wrote:
>
> I usually dedicate an "accounts.bean" to declare all my accounts, and do my daily financing in another file. Currently `beancount-insert-account`(C-c ') only read candidates from current buffer, so it's inconvenient. This patch adds an option to allow user to specify a bunch of files to read completion candidates.
>
> Newly added `files' argument is optional, so won't affect current users. Similar things could be done for links / tags by adding related options, but I left it to your judgment whether it's necessary.
>
>
> --
> You received this message because you are subscribed to the Google Groups "Beancount" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to beancount+...@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/beancount/1fe63852-7193-4a03-89f2-7b8d126af735%40googlegroups.com.

sun...@gmail.com

unread,
Jan 12, 2020, 11:37:31 PM1/12/20
to Beancount
Hi Yiufung,
I see that you have not submitted a pull request for this patch. 
I am also a beancount user and have the same requirements as you. 
In addition, I have fixed two bugs in this patch. 
I wonder if you agree, I will submit this pull request on your behalf?

在 2019年11月9日星期六 UTC+8下午1:22:20,Yiufung Cheong写道:
Reply all
Reply to author
Forward
0 new messages