Please test Pull request 26

[Henner Zeller]

Hi,

I am in the process of finishing reviewing Leonardo's pull request

  https://github.com/hzeller/beagleg/pull/26

Since I am in some rewiring, I don't have my CNC machine currently running, so I'd like you guys patch in the code and see if your CNC machine is working with it. Nothing really should change, but I do like to have some double check on an actual machine :)

Just get the current patch:

  wget https://github.com/hzeller/beagleg/pull/26.diff

.. and apply to your local git

  patch -p1 < 26.diff

Then run your machine a little and report back.

Thanks

  Henner.

[Joe Meadows]

Hi Henner,

Sorry for the slow reply.  I tried this a few days ago and ran into some problems and I've just had time to do some troubleshooting.  Here's a quick recap:

1) Got BeagleG HEAD from GIT

2) Applied patch 26.diff, built and ran BeagleG

When I fired it up the axes didn't move.  It sounded like possibly timing issues, one axis just made a single click, another made a high pitch whine.  Timing issues is just a WAG b/c the machine behaved similarly to this when I was first poking around for the right settings re: BeagleG and my driver board. I backed out the patch and still had the same results.

The version of BeagleG I had been running is fairly recent (about a month old) so I diffed the two trees and found that this change seemed to make the difference:

--- ./am335x_pru_package/pru_sw/app_loader/interface/Makefile   2015-06-23 18:32:03.301175800 +0000

+++ ../beagleg-stock/beagleg/am335x_pru_package/pru_sw/app_loader/interface/Makefile    2017-07-29 17:06:18.670416313 +0000

@@ -9,8 +9,8 @@

 INCLUDEDIR = ../include

 LIBDIR    = ../lib

 

-C_FLAGS += -I. -Wall -I$(INCLUDEDIR)

-

+C_FLAGS += -fPIC -I. -Wall -I$(INCLUDEDIR)

+

 COMPILE.c = $(CC) $(C_FLAGS) $(CPP_FLAGS) -c

 AR.c     = $(AR) rc

 LINK.c   = $(CC) -shared

It's odd that this change was committed on Jan 4, 2017 but I didn't pull this change when I updated the source tree.  When I removed the -fPIC and recompiled the current HEAD things were working again.  Then I re-applied 26.diff and did some basic testing and did not notice any problems.

I only did minimal basic testing of the patch, is there anything specific that you'd like me to try?

Regarding the -fPIC issue, I'm just reporting without really understanding :)  My BBB is a few years old but the OS and tools are up to date.  Happy to provide more info on my setup or try some other tests if you'd like.

Cheers!

Joe