Re: bb-wl18xx-wlan0.service broken if connman is not installed

[Robert Nelson]

On Sun, May 21, 2017 at 10:56 AM, Juliusz Chroboczek <j...@irif.fr> wrote:
> Dear Robert,
>
> bb-wl18xx-wlan0.service causes issues if connman is not installed. There
> are two issues:
>
> 1. On line 183 of /usr/bin/bb-wl18xx-wlan0, it says
>
> connmanctl_bin=$(which connmanctl)
>
> This should say
>
> connmanctl_bin=$(which connmanctl || true)

Thanks!

Pushed the first fix:

https://github.com/rcn-ee/repos/commit/5e56d8c913d9bdc2f2b029a7567d56217998ccb5


>> 2. The .service file says "type=forking", which causes systemd to get in
> a loop restarting the service if the script didn't fork. I've worked
> around it by changing the type to oneshot, but that's obviously not
> workable in general.
>
> I believe the proper solution is to split the script into two parts -- one
> that sets up the firmware, and one that sets up the tether. This would be
> two services, one of type forking, one of type oneshot.

I'll look more into that part this week. I've always assumed connman
would be installed. But for the ubuntu image's that was breaking
things, so now my ubuntu image is connman-less..

Regards,
--
Robert Nelson
https://rcn-ee.com/

[Juliusz Chroboczek]

Dear Robert,

bb-wl18xx-wlan0.service causes issues if connman is not installed. There
are two issues:

1. On line 183 of /usr/bin/bb-wl18xx-wlan0, it says

connmanctl_bin=$(which connmanctl)

This should say

connmanctl_bin=$(which connmanctl || true)

2. The .service file says "type=forking", which causes systemd to get in
a loop restarting the service if the script didn't fork. I've worked
around it by changing the type to oneshot, but that's obviously not
workable in general.

I believe the proper solution is to split the script into two parts -- one
that sets up the firmware, and one that sets up the tether. This would be
two services, one of type forking, one of type oneshot.

Thanks for your help,

-- Juliusz

[Juliusz Chroboczek]

> I'll look more into that part this week. I've always assumed connman
> would be installed.

I find it causes more trouble than it's worth -- I much prefer to
configure my devices statically.

Thanks,

-- Juliusz