[RFC] u-boot patches for REV C4

[Khasim Syed Mohammed]

Hi all,

I am planning to submit these patches (excluding Dirk's REV detection
patch) to u-boot list. Can you please give your comments and
suggestions.

These patches will add
- I2C bus switching logic
- Support to enable 720 Mhz ARM MPU clock on REV C4 boards
- Enables DSS for background on DVI-D and color bar on S-video with
out using FRAMEBUFFERs
- Rev Detection patch from Dirk.

Will send mails with Inline patches as well.

Regards
Khasim

[Khasim Syed Mohammed]

Kindly NOTE, these patches will apply on top of

http://git.denx.de/u-boot-ti.git
git://git.denx.de/u-boot-ti.git

http://git.denx.de/?p=u-boot/u-boot-ti.git;a=summary

Regards,
Khasim

[Syed Mohammed, Khasim]

FYI,

I have submitted these patches to u-boot mailing list. Received
comments for PRCM patch, have re-submitted after incorporating review
comments.

Regards,
Khasim

On Tue, Jan 5, 2010 at 9:11 PM, Khasim Syed Mohammed

<kha...@beagleboard.org> wrote:
> Kindly NOTE, these patches will apply on top of
>
> http://git.denx.de/u-boot-ti.git
> git://git.denx.de/u-boot-ti.git
>
> http://git.denx.de/?p=u-boot/u-boot-ti.git;a=summary
>
> Regards,
> Khasim
>
> On Tue, Jan 5, 2010 at 9:02 PM, Khasim Syed Mohammed
> <kha...@beagleboard.org> wrote:
>> Hi all,
>>
>> I am planning to submit these patches (excluding Dirk's REV detection
>> patch) to u-boot list. Can you please give your comments and
>> suggestions.
>>
>> These patches will add
>> - I2C bus switching logic
>> - Support to enable 720 Mhz ARM MPU clock on REV C4 boards
>> - Enables DSS for background on DVI-D and color bar on S-video with
>> out using FRAMEBUFFERs
>> - Rev Detection patch from Dirk.
>>
>> Will send mails with Inline patches as well.
>>
>> Regards
>> Khasim
>>
>

> --
>
> You received this message because you are subscribed to the Google Groups "Beagle Board" group.
> To post to this group, send email to beagl...@googlegroups.com.
> To unsubscribe from this group, send email to beagleboard...@googlegroups.com.
> For more options, visit this group at http://groups.google.com/group/beagleboard?hl=en.
>
>
>

[Nishanth Menon]

On Wed, Jan 6, 2010 at 8:25 AM, Syed Mohammed, Khasim
<sm.k...@gmail.com> wrote:
> FYI,
>
> I have submitted these patches to u-boot mailing list. Received
> comments for PRCM patch, have re-submitted after incorporating review
> comments.
>

Could you keep the discussion in beagle board OR on u-boot ML? it is a
bit confusing to have discussions in two different places.

[Syed Mohammed, Khasim]

On Wed, Jan 6, 2010 at 7:59 PM, Nishanth Menon <menon.n...@gmail.com> wrote:
> On Wed, Jan 6, 2010 at 8:25 AM, Syed Mohammed, Khasim
> <sm.k...@gmail.com> wrote:
>> FYI,
>>
>> I have submitted these patches to u-boot mailing list. Received
>> comments for PRCM patch, have re-submitted after incorporating review
>> comments.
>>
> Could you keep the discussion in beagle board OR on u-boot ML? it is a
> bit confusing to have discussions in two different places.
>

It is just FYI on beagle mailing list, all discussions about patches
are supposed to happen on u-boot mailing list.

May be I can keep beagle mailing list in CC, will do that next time.

Regards,
Khasim

[Jason Kridner]

On Wed, Jan 6, 2010 at 8:35 AM, Syed Mohammed, Khasim

<sm.k...@gmail.com> wrote:
> On Wed, Jan 6, 2010 at 7:59 PM, Nishanth Menon <menon.n...@gmail.com> wrote:
>> On Wed, Jan 6, 2010 at 8:25 AM, Syed Mohammed, Khasim
>> <sm.k...@gmail.com> wrote:
>>> FYI,
>>>
>>> I have submitted these patches to u-boot mailing list. Received
>>> comments for PRCM patch, have re-submitted after incorporating review
>>> comments.
>>>
>> Could you keep the discussion in beagle board OR on u-boot ML? it is a
>> bit confusing to have discussions in two different places.
>>
> It is just FYI on beagle mailing list, all discussions about patches
> are supposed to happen on u-boot mailing list.
>
> May be I can keep beagle mailing list in CC, will do that next time.

Yeah, cross-posting makes the most sense to me.

>
> Regards,

[Favor Tang]

Hi, when I build u-boot, these patches caused errors. what' the problem is?  and please show me how to solve this.

thanks.

NOTE: Running task 6241 of 6331 (ID: 151, /home/user/Beagle/OE/openembedded/recipes/u-boot/u-boot_git.bb, do_patch)

NOTE: Running task 6247 of 6331 (ID: 134, /home/user/Beagle/OE/openembedded/recipes/mtd/mtd-utils-native_1.2.0+git.bb, do_configure)

NOTE: Applying patch 'new-pinmux.patch' (openembedded/recipes/u-boot/u-boot-git/new-pinmux.patch)

NOTE: Applying patch 'revision-detection.patch' (openembedded/recipes/u-boot/u-boot-git/beagleboard/revision-detection.patch)

ERROR: Error in executing: /home/user/Beagle/OE/openembedded/recipes/u-boot/u-boot_git.bb

ERROR: Exception:<class 'CmdError'> Message:Command Error: exit status: 1  Output:

Applying patch revision-detection.patch

patching file board/ti/beagle/beagle.c

patch: **** malformed patch at line 106: 

Patch revision-detection.patch does not apply (enforce with -f)

ERROR: Printing the environment of the function

ERROR: Error in executing: /home/user/Beagle/OE/openembedded/recipes/u-boot/u-boot_git.bb

ERROR: Exception:<class 'CmdError'> Message:Command Error: exit status: 1  Output:

Applying patch revision-detection.patch

patching file board/ti/beagle/beagle.c

patch: **** malformed patch at line 106: 

Patch revision-detection.patch does not apply (enforce with -f)

ERROR: Printing the environment of the function

ERROR: Error in executing: /home/user/Beagle/OE/openembedded/recipes/u-boot/u-boot_git.bb

ERROR: Exception:<class 'CmdError'> Message:Command Error: exit status: 1  Output:

Applying patch revision-detection.patch

patching file board/ti/beagle/beagle.c

patch: **** malformed patch at line 106: 

Patch revision-detection.patch does not apply (enforce with -f)

ERROR: Printing the environment of the function

ERROR: Build of /home/user/Beagle/OE/openembedded/recipes/u-boot/u-boot_git.bb do_patch failed

Traceback (most recent call last):

  File "/home/user/Beagle/OE/bitbake/bin/bitbake", line 143, in <module>

    main()

  File "/home/user/Beagle/OE/bitbake/bin/bitbake", line 140, in main

    cooker.cook()

  File "/home/user/Beagle/OE/bitbake/lib/bb/cooker.py", line 640, in cook

    return self.buildTargets(pkgs_to_build)

  File "/home/user/Beagle/OE/bitbake/lib/bb/cooker.py", line 547, in buildTargets

    failures = rq.execute_runqueue()

  File "/home/user/Beagle/OE/bitbake/lib/bb/runqueue.py", line 841, in execute_runqueue

    self.execute_runqueue_internal()

  File "/home/user/Beagle/OE/bitbake/lib/bb/runqueue.py", line 950, in execute_runqueue_internal

    self.cooker.tryBuild(fn)

  File "/home/user/Beagle/OE/bitbake/lib/bb/cooker.py", line 136, in tryBuild

    return self.tryBuildPackage(fn, item, self.configuration.cmd, the_data)

  File "/home/user/Beagle/OE/bitbake/lib/bb/cooker.py", line 110, in tryBuildPackage

    bb.build.exec_task('do_%s' % task, the_data)

  File "/home/user/Beagle/OE/bitbake/lib/bb/build.py", line 283, in exec_task

    exec_func(task, localdata)

  File "/home/user/Beagle/OE/bitbake/lib/bb/build.py", line 120, in exec_func

    exec_func_python(func, d)

  File "/home/user/Beagle/OE/bitbake/lib/bb/build.py", line 141, in exec_func_python

    utils.better_exec(comp, g, tmp, bbfile)

  File "/home/user/Beagle/OE/bitbake/lib/bb/utils.py", line 185, in better_exec

    exec code in context

  File "do_patch", line 4, in <module>

  File "do_patch", line 2, in do_patch

  File "/home/user/Beagle/OE/bitbake/lib/bb/build.py", line 120, in exec_func

    exec_func_python(func, d)

  File "/home/user/Beagle/OE/bitbake/lib/bb/build.py", line 141, in exec_func_python

    utils.better_exec(comp, g, tmp, bbfile)

  File "/home/user/Beagle/OE/bitbake/lib/bb/utils.py", line 185, in better_exec

    exec code in context

  File "base_do_patch", line 4, in <module>

  File "base_do_patch", line 2, in base_do_patch

  File "/home/user/Beagle/OE/bitbake/lib/bb/build.py", line 120, in exec_func

    exec_func_python(func, d)

  File "/home/user/Beagle/OE/bitbake/lib/bb/build.py", line 141, in exec_func_python

    utils.better_exec(comp, g, tmp, bbfile)

  File "/home/user/Beagle/OE/bitbake/lib/bb/utils.py", line 185, in better_exec

    exec code in context

  File "patch_do_patch", line 98, in <module>

  File "patch_do_patch", line 96, in patch_do_patch

  File "<bb>", line 361, in Resolve

__builtin__.CmdError: Command Error: exit status: 1  Output:

Applying patch revision-detection.patch

patching file board/ti/beagle/beagle.c

patch: **** malformed patch at line 106: 

Patch revision-detection.patch does not apply (enforce with -f)

NOTE: Running task 6248 of 6331 (ID: 135, /home/user/Beagle/OE/openembedded/recipes/mtd/mtd-utils-native_1.2.0+git.bb, do_qa_configure)

ERROR: Task 151 (/home/user/Beagle/OE/openembedded/recipes/u-boot/u-boot_git.bb, do_patch) failed

NOTE: Waiting for 1 active tasks to finish

NOTE: 1: /home/user/Beagle/OE/openembedded/recipes/mtd/mtd-utils-native_1.2.0+git.bb, do_qa_configure (21795)

NOTE: Tasks Summary: Attempted 6246 tasks of which 6245 didn't need to be rerun and 1 failed.

ERROR: '/home/user/Beagle/OE/openembedded/recipes/u-boot/u-boot_git.bb' failed

[h...@computer.org]

For me patching worked (by using -p1 flag)

2 ideas:
a) patch file encoding after download (crlf problem)
b) did you not apply patch to git://git.denx.de/u-boot-ti.git

> On Fri, Jan 8, 2010 at 8:48 PM, Jason Kridner <jkrid...@beagleboard.org>wrote:
>
>
>
> > On Wed, Jan 6, 2010 at 8:35 AM, Syed Mohammed, Khasim

> > <sm.kha...@gmail.com> wrote:
> > > On Wed, Jan 6, 2010 at 7:59 PM, Nishanth Menon <menon.nisha...@gmail.com>

> > wrote:
> > >> On Wed, Jan 6, 2010 at 8:25 AM, Syed Mohammed, Khasim
> > >> <sm.kha...@gmail.com> wrote:
> > >>> FYI,
>
> > >>> I have submitted these patches to u-boot mailing list. Received
> > >>> comments for PRCM patch, have re-submitted after incorporating review
> > >>> comments.
>
> > >> Could you keep the discussion in beagle board OR on u-boot ML? it is a
> > >> bit confusing to have discussions in two different places.
>
> > > It is just FYI on beagle mailing list, all discussions about patches
> > > are supposed to happen on u-boot mailing list.
>
> > > May be I can keep beagle mailing list in CC, will do that next time.
>
> > Yeah, cross-posting makes the most sense to me.
>
> > > Regards,
> > > Khasim
>
> > > --
> > > You received this message because you are subscribed to the Google Groups
> > "Beagle Board" group.
> > > To post to this group, send email to beagl...@googlegroups.com.
> > > To unsubscribe from this group, send email to

> > beagleboard...@googlegroups.com<beagleboard%2Bunsubscribe@googlegr oups.com>

> > .
> > > For more options, visit this group at
> >http://groups.google.com/group/beagleboard?hl=en.
>
> > --
> > You received this message because you are subscribed to the Google Groups
> > "Beagle Board" group.
> > To post to this group, send email to beagl...@googlegroups.com.
> > To unsubscribe from this group, send email to

> > beagleboard...@googlegroups.com<beagleboard%2Bunsubscribe@googlegr oups.com>

[Favor Tang]

hi, 

   it's problem of "crlf". I download these patches via "git pull" from openembedded repo.

others may meet this problem like me, I hope someone would note this and will fix this in OE.

thanks

To unsubscribe from this group, send email to beagleboard...@googlegroups.com.