Can I use BBR with fq_codel?

3620 views
Skip to first unread message

naner...@gmail.com

unread,
Jan 16, 2017, 2:18:39 AM1/16/17
to BBR Development
I know in the README, BBR team suggests fq, but does using fq_codel has any negative impact?

Thanks,
Eric

Neal Cardwell

unread,
Jan 16, 2017, 9:43:08 AM1/16/17
to naner...@gmail.com, BBR Development
BBR requires pacing. The Linux fq_codel qdisc does not implement pacing, so fq_codel would not be sufficient.

So the note in the tcp_bbr.c code is still current and complete:

   NOTE: BBR *must* be used with the fq qdisc ("man tc-fq") with pacing enabled,
   since pacing is integral to the BBR design and implementation.
   BBR without pacing would not function properly, and may incur unnecessary
   high packet loss rates.

neal


--
You received this message because you are subscribed to the Google Groups "BBR Development" group.
To unsubscribe from this group and stop receiving emails from it, send an email to bbr-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

naner...@gmail.com

unread,
Jan 17, 2017, 12:05:59 AM1/17/17
to BBR Development, naner...@gmail.com
Thank you, Neal.

Another question:
How does ECN impact BBR? Should I disable ECN?


在 2017年1月16日星期一 UTC+8下午10:43:08,Neal Cardwell写道:
BBR requires pacing. The Linux fq_codel qdisc does not implement pacing, so fq_codel would not be sufficient.

So the note in the tcp_bbr.c code is still current and complete:

   NOTE: BBR *must* be used with the fq qdisc ("man tc-fq") with pacing enabled,
   since pacing is integral to the BBR design and implementation.
   BBR without pacing would not function properly, and may incur unnecessary
   high packet loss rates.

neal

On Mon, Jan 16, 2017 at 2:18 AM, <naner...@gmail.com> wrote:
I know in the README, BBR team suggests fq, but does using fq_codel has any negative impact?

Thanks,
Eric

--
You received this message because you are subscribed to the Google Groups "BBR Development" group.
To unsubscribe from this group and stop receiving emails from it, send an email to bbr-dev+u...@googlegroups.com.

Jonathan Morton

unread,
Jan 17, 2017, 2:33:51 AM1/17/17
to naner...@gmail.com, BBR Development

> On 17 Jan, 2017, at 07:05, naner...@gmail.com wrote:
>
> How does ECN impact BBR? Should I disable ECN?

I believe the current Linux implementation of BBR ignores ECN. Given that, it would be more RFC-compliant to set "sysctl net.ipv4.tcp_ecn=0”. You can (and should) leave it on in any qdiscs you’re running.

- Jonathan Morton

Jim Gettys

unread,
Jan 17, 2017, 10:22:48 AM1/17/17
to Neal Cardwell, naner...@gmail.com, BBR Development
On Mon, Jan 16, 2017 at 9:42 AM, 'Neal Cardwell' via BBR Development <bbr...@googlegroups.com> wrote:
BBR requires pacing. The Linux fq_codel qdisc does not implement pacing, so fq_codel would not be sufficient.

​Patches gratefully accepted.  Also, there is a new qdisc based on fq_codel called "cake" that could use pacing, that is particularly useful at the edge of the network.  And the new code for WiFi that is showing stunning results could also use pacing magic, I expect.

The network you may improve may be close to home ;-).
                                                           - Jim

Eric Dumazet

unread,
Jan 17, 2017, 10:42:49 AM1/17/17
to BBR Development, ncar...@google.com, naner...@gmail.com
Few observations, just in case these points are not already known.

1) fq_codel purpose is to be used at the bottleneck point. Typically a router, an access point.

2) fq_codel is based on a stochastic hash. Multiple flows can collide in a hash bucket.

3) fq is implementing pacing, and is meant for end hosts. It was designed with performance in mind.
   Codel was not added there, because it was not needed (see point 1)), and only adding wasting cpu cycles.

4) Most of end hosts can usually send much faster than the bottlenecks their TCP flow might reach.

5) BBR just reacts fine in the rare case the bottleneck is right at the host itself.

In other words, you can install fq on your laptop or typical linux device, then you can use BBR right now.

For the few people that absolutely want their Access Point being able to initiate its own TCP flows,
and these TCP flows might saturate the bottleneck,
we will add a fallback to TCP stack.

TCP stack will implement its own pacing when it detects FQ is not installed/used.

At a performance cost, but who cares really.
 

On Tuesday, January 17, 2017 at 7:22:48 AM UTC-8, Jim Gettys wrote:
On Mon, Jan 16, 2017 at 9:42 AM, 'Neal Cardwell' via BBR Development <bbr...@googlegroups.com> wrote:
BBR requires pacing. The Linux fq_codel qdisc does not implement pacing, so fq_codel would not be sufficient.

​Patches gratefully accepted.  Also, there is a new qdisc based on fq_codel called "cake" that could use pacing, that is particularly useful at the edge of the network.  And the new code for WiFi that is showing stunning results could also use pacing magic, I expect.

The network you may improve may be close to home ;-).
                                                           - Jim
 

So the note in the tcp_bbr.c code is still current and complete:

   NOTE: BBR *must* be used with the fq qdisc ("man tc-fq") with pacing enabled,
   since pacing is integral to the BBR design and implementation.
   BBR without pacing would not function properly, and may incur unnecessary
   high packet loss rates.

neal

On Mon, Jan 16, 2017 at 2:18 AM, <naner...@gmail.com> wrote:
I know in the README, BBR team suggests fq, but does using fq_codel has any negative impact?

Thanks,
Eric

--
You received this message because you are subscribed to the Google Groups "BBR Development" group.
To unsubscribe from this group and stop receiving emails from it, send an email to bbr-dev+u...@googlegroups.com.

For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "BBR Development" group.
To unsubscribe from this group and stop receiving emails from it, send an email to bbr-dev+u...@googlegroups.com.

naner...@gmail.com

unread,
Jan 17, 2017, 10:24:12 PM1/17/17
to BBR Development, ncar...@google.com, naner...@gmail.com
BBR+FQ:

BBR+FQ_CODEL:


在 2017年1月17日星期二 UTC+8下午11:42:49,Eric Dumazet写道:
Auto Generated Inline Image 1
Auto Generated Inline Image 2

Eric Dumazet

unread,
Jan 17, 2017, 10:44:21 PM1/17/17
to BBR Development, ncar...@google.com, naner...@gmail.com
Please, do not post graphs or anything with BBR+<whatever qdisc that is not FQ>.

If you want to impress your friends, just blast packets with UDP and no congestion control.
You will get line rate.

Repeat : BBR without proper pacing (which currently is only ensured by FQ) is not supported.
You are likely to have serious problems if you plan doing that at scale.

 https://www.ietf.org/rfc/rfc2119.txt is a good resource in case the words "MUST"  or "REQUIRED" are not familiar.

Zagfai Kwong

unread,
Jul 31, 2017, 8:30:27 AM7/31/17
to BBR Development, ncar...@google.com, naner...@gmail.com
I don't understand.
It seems that BBR with fq_codel runs well.

Eric Dumazet

unread,
Jul 31, 2017, 8:33:56 AM7/31/17
to Zagfai Kwong, BBR Development, Neal Cardwell, naner...@gmail.com
BBR will run well with fq_codel only after linux-4.13 (not yet released)

Before linux-4.13, BBR _needs_  fq packet scheduler.

fq is not fq_codel.


To unsubscribe from this group and stop receiving emails from it, send an email to bbr-dev+unsubscribe@googlegroups.com.

Zagfai Kwong

unread,
Jul 31, 2017, 11:07:30 AM7/31/17
to BBR Development, zag...@gmail.com, ncar...@google.com, naner...@gmail.com
But in fact it runs well with fq_codel in linux 4.9.
I use BBR for a high loss rate network which high up to 15%, and it solve the problem using cubie.

Eric Dumazet

unread,
Jul 31, 2017, 11:31:13 AM7/31/17
to Zagfai Kwong, BBR Development, Neal Cardwell, naner...@gmail.com
This is not a supported configuration.

If many people/hosts were using this configuration, danger of hurting Internet traffic would be high.

If you want to blast packets, just use UDP and be happy.



To unsubscribe from this group and stop receiving emails from it, send an email to bbr-dev+unsubscribe@googlegroups.com.

Neal Cardwell

unread,
Jul 31, 2017, 11:45:26 AM7/31/17
to Zagfai Kwong, BBR Development, naner...@gmail.com
It depends on what one means by "runs well". :-)

It can be said that BBR "runs well" with fq_codel in linux 4.9, in the sense of achieving high throughput. But, as Eric points out, the problem is that without some sort of pacing BBR will inject too many packets into the network too quickly. In that sense, BBR without pacing does not run well.

See section 4.3.4.4. "Restarting From Idle" in the BBR Internet Draft for a discussion of related issues:


Without pacing in place, BBR would behave like the "BDP-scale line-rate burst" approach mentioned in that section.

And beyond that, BBR without pacing keeps more packets in flight than the algorithm intends (because the algorithm periodically uses lower pacing rates to drain packets out of the bottleneck queue).

neal

Zagfai Kwong

unread,
Jul 31, 2017, 3:57:10 PM7/31/17
to BBR Development, zag...@gmail.com, naner...@gmail.com
Thank you for your explanation.
That is to say, it would affect other users seriously in some case that bbr+fq_codel.
Thank you.
Reply all
Reply to author
Forward
0 new messages