[S] Change in bazel/bazel[master]: upgrade asm to 9.10

0 views
Skip to first unread message

Hee Cha (xWF) (Gerrit)

unread,
Jun 1, 2026, 5:58:17 PM (2 days ago) Jun 1
to bazel-...@googlegroups.com

Hee Cha (xWF) has uploaded the change for review

Commit message

upgrade asm to 9.10

https://github.com/bazelbuild/bazel/issues/29568

Partial commit for third_party/*, see #29630.
Change-Id: I63b712bd644a157d2f09d8aac8ff2cbad7530cc3
Signed-off-by: iancha1992 <he...@google.com>

Change information

Files:
  • M third_party/BUILD
  • M third_party/java/jacoco/BUILD
Change size: S
Delta: 2 files changed, 17 insertions(+), 17 deletions(-)
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedVerified
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: bazel
Gerrit-Branch: master
Gerrit-Change-Id: I63b712bd644a157d2f09d8aac8ff2cbad7530cc3
Gerrit-Change-Number: 329191
Gerrit-PatchSet: 1
Gerrit-Owner: Hee Cha (xWF) <he...@google.com>
unsatisfied_requirement
open
diffy

Hee Cha (xWF) (Gerrit)

unread,
Jun 1, 2026, 5:59:16 PM (2 days ago) Jun 1
to Charles Mita, Xudong Yang
Attention needed from Charles Mita and Xudong Yang

Hee Cha (xWF) voted

Code-Review+2
Presubmit-Ready+2
Verified+1
Open in Gerrit

Related details

Attention is currently required from:
  • Charles Mita
  • Xudong Yang
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
  • requirement satisfiedVerified
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: bazel
Gerrit-Branch: master
Gerrit-Change-Id: I63b712bd644a157d2f09d8aac8ff2cbad7530cc3
Gerrit-Change-Number: 329191
Gerrit-PatchSet: 1
Gerrit-Owner: Hee Cha (xWF) <he...@google.com>
Gerrit-Reviewer: Charles Mita <cm...@google.com>
Gerrit-Reviewer: Hee Cha (xWF) <he...@google.com>
Gerrit-Reviewer: Xudong Yang <w...@google.com>
Gerrit-Attention: Charles Mita <cm...@google.com>
Gerrit-Attention: Xudong Yang <w...@google.com>
Gerrit-Comment-Date: Mon, 01 Jun 2026 21:59:12 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Hee Cha (xWF) (Gerrit)

unread,
Jun 1, 2026, 5:59:41 PM (2 days ago) Jun 1
to Charles Mita, Xudong Yang
Attention needed from Charles Mita and Xudong Yang

Hee Cha (xWF) added 1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Hee Cha (xWF) . resolved

Other non-third party changes are in: https://critique.corp.google.com/cl/924909929

Open in Gerrit

Related details

Attention is currently required from:
  • Charles Mita
  • Xudong Yang
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
  • requirement satisfiedVerified
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: bazel
Gerrit-Branch: master
Gerrit-Change-Id: I63b712bd644a157d2f09d8aac8ff2cbad7530cc3
Gerrit-Change-Number: 329191
Gerrit-PatchSet: 1
Gerrit-Owner: Hee Cha (xWF) <he...@google.com>
Gerrit-Reviewer: Charles Mita <cm...@google.com>
Gerrit-Reviewer: Hee Cha (xWF) <he...@google.com>
Gerrit-Reviewer: Xudong Yang <w...@google.com>
Gerrit-Attention: Charles Mita <cm...@google.com>
Gerrit-Attention: Xudong Yang <w...@google.com>
Gerrit-Comment-Date: Mon, 01 Jun 2026 21:59:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Hee Cha (xWF) (Gerrit)

unread,
Jun 1, 2026, 6:10:58 PM (2 days ago) Jun 1
to bazel-...@googlegroups.com

Hee Cha (xWF) abandoned this change.

View Change

Abandoned

Hee Cha (xWF) abandoned this change

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
  • requirement satisfiedVerified
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: abandon
Gerrit-Project: bazel
Gerrit-Branch: master
Gerrit-Change-Id: I63b712bd644a157d2f09d8aac8ff2cbad7530cc3
Gerrit-Change-Number: 329191
Gerrit-PatchSet: 1
Gerrit-Owner: Hee Cha (xWF) <he...@google.com>
Gerrit-Reviewer: Hee Cha (xWF) <he...@google.com>
satisfied_requirement
unsatisfied_requirement
open
diffy

Hee Cha (xWF) (Gerrit)

unread,
Jun 1, 2026, 6:11:48 PM (2 days ago) Jun 1
to bazel-...@googlegroups.com

Hee Cha (xWF) has uploaded the change for review

Commit message

upgrade asm to 9.10

https://github.com/bazelbuild/bazel/issues/29568

Partial commit for third_party/*, see #29630.
Change-Id: I539b33105e10d62913ada28f6f9e635b3ad27b5d
Signed-off-by: iancha1992 <he...@google.com>

Change information

Files:
  • M third_party/BUILD
  • M third_party/java/jacoco/BUILD
Change size: S
Delta: 2 files changed, 17 insertions(+), 17 deletions(-)
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedVerified
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: bazel
Gerrit-Branch: master
Gerrit-Change-Id: I539b33105e10d62913ada28f6f9e635b3ad27b5d
Gerrit-Change-Number: 329192
unsatisfied_requirement
open
diffy

Hee Cha (xWF) (Gerrit)

unread,
Jun 1, 2026, 6:14:32 PM (2 days ago) Jun 1
to Xudong Yang, Charles Mita
Attention needed from Charles Mita and Xudong Yang

Hee Cha (xWF) voted and added 1 comment

Votes added by Hee Cha (xWF)

Code-Review+2
Presubmit-Ready+2
Verified+1

1 comment

Patchset-level comments
Hee Cha (xWF) . resolved

I took out the changes for `third_party/BUILD` file because https://critique.corp.google.com/cl/924909929 already has the change. @w...@google.com @cm...@google.com

Open in Gerrit

Related details

Attention is currently required from:
  • Charles Mita
  • Xudong Yang
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
  • requirement satisfiedVerified
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: bazel
Gerrit-Branch: master
Gerrit-Change-Id: I539b33105e10d62913ada28f6f9e635b3ad27b5d
Gerrit-Change-Number: 329192
Gerrit-PatchSet: 1
Gerrit-Owner: Hee Cha (xWF) <he...@google.com>
Gerrit-Reviewer: Charles Mita <cm...@google.com>
Gerrit-Reviewer: Hee Cha (xWF) <he...@google.com>
Gerrit-Reviewer: Xudong Yang <w...@google.com>
Gerrit-Attention: Charles Mita <cm...@google.com>
Gerrit-Attention: Xudong Yang <w...@google.com>
Gerrit-Comment-Date: Mon, 01 Jun 2026 22:14:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Xudong Yang (Gerrit)

unread,
Jun 1, 2026, 6:17:26 PM (2 days ago) Jun 1
to Hee Cha (xWF), Charles Mita
Attention needed from Charles Mita and Hee Cha (xWF)

Xudong Yang added 1 comment

Patchset-level comments
Hee Cha (xWF) . resolved

I took out the changes for `third_party/BUILD` file because https://critique.corp.google.com/cl/924909929 already has the change. @w...@google.com @cm...@google.com

Xudong Yang

but it looks like third_party/BUILD still has changes in this CL?

Open in Gerrit

Related details

Attention is currently required from:
  • Charles Mita
  • Hee Cha (xWF)
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
  • requirement satisfiedVerified
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: bazel
Gerrit-Branch: master
Gerrit-Change-Id: I539b33105e10d62913ada28f6f9e635b3ad27b5d
Gerrit-Change-Number: 329192
Gerrit-PatchSet: 1
Gerrit-Owner: Hee Cha (xWF) <he...@google.com>
Gerrit-Reviewer: Charles Mita <cm...@google.com>
Gerrit-Reviewer: Hee Cha (xWF) <he...@google.com>
Gerrit-Reviewer: Xudong Yang <w...@google.com>
Gerrit-Attention: Charles Mita <cm...@google.com>
Gerrit-Attention: Hee Cha (xWF) <he...@google.com>
Gerrit-Comment-Date: Mon, 01 Jun 2026 22:17:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hee Cha (xWF) <he...@google.com>
satisfied_requirement
unsatisfied_requirement
open
diffy

Xudong Yang (Gerrit)

unread,
Jun 1, 2026, 6:37:01 PM (2 days ago) Jun 1
to Hee Cha (xWF), Charles Mita
Attention needed from Charles Mita and Hee Cha (xWF)

Xudong Yang voted Code-Review+2

Code-Review+2
Open in Gerrit

Related details

Attention is currently required from:
  • Charles Mita
  • Hee Cha (xWF)
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
  • requirement satisfiedVerified
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: bazel
Gerrit-Branch: master
Gerrit-Change-Id: I539b33105e10d62913ada28f6f9e635b3ad27b5d
Gerrit-Change-Number: 329192
Gerrit-PatchSet: 2
Gerrit-Owner: Hee Cha (xWF) <he...@google.com>
Gerrit-Reviewer: Charles Mita <cm...@google.com>
Gerrit-Reviewer: Hee Cha (xWF) <he...@google.com>
Gerrit-Reviewer: Xudong Yang <w...@google.com>
Gerrit-Attention: Charles Mita <cm...@google.com>
Gerrit-Attention: Hee Cha (xWF) <he...@google.com>
Gerrit-Comment-Date: Mon, 01 Jun 2026 22:36:57 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Xudong Yang (Gerrit)

unread,
Jun 1, 2026, 6:37:19 PM (2 days ago) Jun 1
to Hee Cha (xWF), Charles Mita

Xudong Yang submitted the change

Change information

Commit message:
upgrade asm to 9.10

https://github.com/bazelbuild/bazel/issues/29568

Partial commit for third_party/*, see #29630.
Change-Id: I539b33105e10d62913ada28f6f9e635b3ad27b5d
Signed-off-by: iancha1992 <he...@google.com>
Files:
  • M third_party/java/jacoco/BUILD
Change size: XS
Delta: 1 file changed, 3 insertions(+), 3 deletions(-)
Branch: refs/heads/master
Submit Requirements:
  • requirement satisfiedCode-Review: +2 by Xudong Yang
  • requirement satisfiedVerified: +1 by Hee Cha (xWF)
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages